Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cleanup imports/exports #1269

Merged
merged 6 commits into from
Dec 17, 2024
Merged

fix: Cleanup imports/exports #1269

merged 6 commits into from
Dec 17, 2024

Conversation

Nerivec
Copy link
Collaborator

@Nerivec Nerivec commented Dec 17, 2024

  • Avoid importing as much as possible
    • For Adapter.create this should make startup better by avoiding imports of all adapter classes (even if just for a short time then GC'ed). Since auto-typing is not possible with variable-path, added jest test to ensure proper class always returned from simple create call.
  • Export stuff to be able to refactor the various from 'zigbee-herdsman/dist/...
  • Remove stale util realpathsync
  • Cleanup test mocks
  • Fix some setTimeout mocks

@Koenkk Koenkk merged commit 6fde32f into Koenkk:master Dec 17, 2024
1 check passed
@Koenkk
Copy link
Owner

Koenkk commented Dec 17, 2024

Some nice cleanups, thanks!

@Nerivec Nerivec deleted the imports-exports branch December 17, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants