Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all commands #1088

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Expose all commands #1088

merged 3 commits into from
Jun 14, 2024

Conversation

Koenkk
Copy link
Owner

@Koenkk Koenkk commented Jun 13, 2024

This PR makes zigbee-herdsman expose all commands. Currently it is filtered through CommandsLookup which became messy already. With the introduction of custom clusters this filtering has become a problem, since custom commands never emit events. This PR removes the CommandsLookup entirely.

Should be merged together with Koenkk/zigbee-herdsman-converters#7634 since some commands didn't follow the naming convention.

@Koenkk Koenkk merged commit 6d1838a into master Jun 14, 2024
2 checks passed
@Koenkk Koenkk deleted the feat/expose-all-commands branch June 14, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants