feat: Improved adapter discovery.

[Nerivec]

TODO:

• Update Adapter.create (should remove most of the logic)
• Remove adapter.autoDetectPath, adapter.isValidPath and definitions in all drivers
• Complete fingerprints. Closes feat: add auto-detection of CC2652P #1071

[Nerivec]

@kirovilya Can you provide a fingerprint for the nordic adapter? I'll clean up the matching/tests with it.

import {SerialPort} from 'zigbee-herdsman/dist/adapter/serialPort.js';

const list = await SerialPort.list();

console.log(list);

[kirovilya]

@kirovilya Can you provide a fingerprint for the nordic adapter? I'll clean up the matching/tests with it.

for this? https://github.com/Koenkk/zigbee-herdsman/blob/master/src/adapter/zboss/adapter/zbossAdapter.ts#L24

[Nerivec]

Whatever comes out of the bit of code I mentioned above should have it all; mostly the path. This PR improves upon the discovery a bit, more refined using regex matching against the paths.

See the adapterDiscovery.ts file in the PR, in case you can provide more missing fingerprints 😉

[kirovilya]

Whatever comes out of the bit of code I mentioned above should have it all; mostly the path. This PR improves upon the discovery a bit, more refined using regex matching against the paths.

See the adapterDiscovery.ts file in the PR, in case you can provide more missing fingerprints 😉

{
    manufacturer: 'ZEPHYR',
    serialNumber: '54ACCFAFA6DADC49',
    pnpId: 'usb-ZEPHYR_Zigbee_NCP_54ACCFAFA6DADC49-if00',
    locationId: undefined,
    vendorId: '2fe3',
    productId: '0100',
    path: '/dev/ttyACM0'
  },

and in windows

  {
  path: 'COM22',
  manufacturer: 'Корпорация Майкрософт',
  serialNumber: '6&11E6BDCD&1&0000',
  pnpId: 'USB\\VID_2FE3&PID_0100&MI_00\\6&11E6BDCD&1&0000',
  locationId: '0000.0014.0000.009.000.000.000.000.000',
  friendlyName: 'Устройство с последовательным интерфейсом USB (COM22)',
  vendorId: '2FE3',
  productId: '0100'
},

[kirovilya]

there is also a proposal to extract the serial port from the adapters and transfer the ready-made connection inside.
connection and reconnection control can also be performed outside the adapter

[Nerivec]

It would require adding more variables to Adapter that can be overridden in subclasses to have the proper settings for serial/socket ports (hw/sw, stop bits, parity, watermark, etc.) since these can vary. Parser/writer would have to stay in adapters too, since these are very different in most cases (or would require an even bigger refactoring).
Probably wouldn't be bad to have just the writer instance and a parser callback function passed to adapters, but at first glance, it's a pretty large refactor.

[Nerivec]

@tube0013 Can you take a look at the TubesZB fingerprints and confirm the data? If you can also provide the fingerprints for your other devices, that'd be great.

[tube0013]

I'm going to be adopting the generic zeroconf/mdns discovery coming to HA/ZHA: home-assistant/core#126294

[Nerivec]

These are for USB. You don't have any USB device? I found a couple of fingerprints in zigpy code, but maybe they are no longer relevant?

[tube0013]

my bad I should read, this info is still valid: https://github.com/home-assistant/core/blob/dcb6c9a13375d5db73211f250a52c5342d36307d/homeassistant/components/zha/manifest.json#L51

through L57.

[Nerivec]

Did you set the manufacturer property as well? (that would add an extra bit of info to match against).

[tube0013]

I set product string to "TubesZB" and serial is set as 971207DO or 971229NY

At least on the ch340b I'm not aware how to write a manufacturer string.