Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second PR to implement Koenkk/zigbee2mqtt#17177.
It is mostly a refactor to make future PRs more easily understandable. Apart from one fix to the previous PR, it does not change the current behavior (i.e. tests are only adapted to reflect the changes in the type definitions).
Changes:
PendingRequest
a class and rename it toRequest
. The ZclFrame is taken out of the func() as a separate member of the Request class, to make it accessible for message filtering. The class also includes some member functions to e.g. handle reject/resolve callbacks from multiple send requests.pendingRequests
fromArray
toSet
, which handles asynchronous addition and removal of elements better, and allows to get rid of copying the pendingRequests array back and forth during sending. Apart from that, Set and Array should behave identically for us. A Set will not allow multiple identical elements, but queued requests should always differ, at least in their frame counter.I was not sure where the best place to put the new classes and types would be. So lmk if there is a better location and I will move them there.