Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning that input 2 is not supported for Philips wall switch #2953

Conversation

juanpescador
Copy link

Is the warning still relevant? Actions are reported for both inputs out of the box for me with Z2M 1.39.1 and firmware version 1.0.3 (build date 20210115). I did click on "dual_rocker" before recording the GIF, not sure if that had an impact (when going back to the "Exposes" tab in the recording, it no longer displays which device mode is enabled).

2022-08-17 Philips Hue wall switch both inputs work

Also I've edited the GIF, pausing on the frames where the action is visible. In real life the transitions are much faster.

@juanpescador
Copy link
Author

Looking through the edit history of this file, it looks like the disclaimer applies (or applied) to group binding. Should I edit the disclaimer rather than remove it then?

For reference, the disclaimer was added in 7f05e31, which referred to zigbee2mqtt issue 10740:

As written earlier in this thread, it is possible to make this device send toggle commands to Zigbee groups. To enable this some fixes where required. These are available in the latest-dev branch now. I documented how to accomplish the group binding: https://github.com/Koenkk/zigbee2mqtt.io/blob/develop/docs/devices/929003017102.md#directly-control-zigbee-groups

To clarify.. this only works for one of the input/side of switch, right?

Originally posted by @martijn-brant in Koenkk/zigbee2mqtt#10740 (comment)

@martijn-brant
Copy link

This device always had two working inputs. The warning was for when using direct binding to groups (allowing the wall switch to control the lights even when Z2m / controller software is down). So please don't remove this warning as it applies to the binding scenario, not the normal usage scenario.

@juanpescador
Copy link
Author

The warning was for when using direct binding to groups

Indeed, that's what I found looking through the file history. After playing around with it and trying to bind it to a group things came together. For first-time readers I think it's worth rewording; it seemed like the limitation applied in all cases. I'll open another PR with a proposal, see what everyone thinks.

@markuswebert
Copy link
Contributor

@martijn-brant Sorry for writing on a closed issue.. I wondered if there are any information about the direct binding issue with the second input available? What is the restricting part? The wall switch firmware? Read about this restriction multiple times but I was not able find more details. Thanks!

@bjornarfjelldal
Copy link

I am also keen on figuring out if this is a hard restriction. What it basically does is prevent the use of the second rocker in a double-rocker configuration, as both inputs control the same group in a binding. And for binding to work well and not drain battery, we cannot use the actions sent to the coordinator as they are not sent when removing those bindings. @martijn-brant @markuswebert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants