Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for device Hue Outdoor Econic wall lantern Philips #5542

Closed
vinta7 opened this issue Jan 4, 2021 · 6 comments
Closed

Support for device Hue Outdoor Econic wall lantern Philips #5542

vinta7 opened this issue Jan 4, 2021 · 6 comments

Comments

@vinta7
Copy link

vinta7 commented Jan 4, 2021

Hi.
I have several 'Hue Outdoor Econic wall lantern Philips 1744030P7' lamps outside, can someone please make support for these ?, today there is support for 'Hue Outdoor Econic wall lantern Philips 1743930P7', the only difference between the 2 versions is the psychical mounting of the support arm, 1744030P7 have the arm on the top, 1743930P7 have the arm in the bottom. So it should be an copy/paste 1743930P7 -> 1744030P7 with a different picture.
Regards
1744030P7
new picture

@sjorge
Copy link
Contributor

sjorge commented Jan 4, 2021

You can update devices.js to see if it works when you change:

zigbeeModel: ['1743930P7']

to

zigbeeModel: ['1743930P7', '1744030P7']

Here https://github.com/Koenkk/zigbee-herdsman-converters/blob/124b9fface70e399236bd2665c4da3a4b3a2bc1e/devices.js#L2917

If it works, you can make a PR (or I can do it)

@vinta7
Copy link
Author

vinta7 commented Jan 5, 2021

Thanks for the update, I will try it soon but I having some issues with hassio-zigbee2mqtt.

@svrooij
Copy link

svrooij commented Jan 6, 2021

@sjorge you should copy the permalink to the line, that file is changing a lot so a specific line in master might be a different line tomorrow.

@sjorge
Copy link
Contributor

sjorge commented Jan 6, 2021

@sjorge you should copy the permalink to the line, that file is changing a lot so a specific line in master might be a different line tomorrow.

Probably a good idea yeah, fixed

@vinta7
Copy link
Author

vinta7 commented Jan 14, 2021

Hi, it works great, I would be grateful if you could update the repository for me :-), I am a newbie on github

@Koenkk
Copy link
Owner

Koenkk commented Jan 15, 2021

Closing this as Koenkk/zigbee-herdsman-converters#2081 is merged. Thanks for helping out @sjorge

Changes will be available in the latest dev branch in a few hours (https://www.zigbee2mqtt.io/how_tos/how-to-switch-to-dev-branch.html)

@Koenkk Koenkk closed this as completed Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants