Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_mireds from bulbs in a group is not exposed to HA during auto discovery. #8032

Closed
LucidityCrash opened this issue Jul 13, 2021 · 5 comments
Labels
problem Something isn't working

Comments

@LucidityCrash
Copy link

LucidityCrash commented Jul 13, 2021

What happened

Light group auto discovered in HA from z2m doesn't have max_mireds property

What did you expect to happen

Both the bulbs in the group (Zigbee 3.0 LED-bulb, RGBW LED) have a max_mireds value (Koenkk/zigbee-herdsman-converters@ecabe5b) I expected this to be exposed in the group discovery config and it is not so the discovered light entity in HA has a temperature slider that can go up to 500. When I was adding this manually to HA the max temperature on the slicer is limited to max_mireds.

How to reproduce it (minimal and precise)

Add lights that have a non default max_mireds (ie not 500) to a group. The discovered light entity in HA has a temperature slider that can go up to 500

Debug info

Zigbee2MQTT version: 1.20.0 commit: 41b67fd

Could class this as a feature request as you could say it is a bit of missing functionality rather than something being broken :)

@LucidityCrash LucidityCrash added the problem Something isn't working label Jul 13, 2021
@jwoodard80
Copy link

I actually just noticed this as well. I have 4 identical bulbs that run 153-370. I was able to edit the definition of the bulb and a PR was submitted by someone but the group does not have a place for that.

Might I suggest an option in the configuration.yaml to define a max/min if we are not pulling a value?

@Koenkk
Copy link
Owner

Koenkk commented Jul 14, 2021

Added, please let me know if it works.

Changes will be available in the dev branch in a few hours from now. (https://www.zigbee2mqtt.io/how_tos/how-to-switch-to-dev-branch.html)

@jwoodard80
Copy link

Thank you very much for this! Appreciate the quick addition!

@Koenkk
Copy link
Owner

Koenkk commented Jul 15, 2021

Need some input on this discussion I'm having with @sjorge here: 515599a#r53518817

Currently if a group has 2 bulbs with different color temperatures ranges:

  • bulb A: range 100 - 350
  • bulb B: range 150 - 400

In the current implementation (solution A), the range is set to the maximum one (in this case 100 - 400). However if you would now set the group color temperature to lets say 370 it would result in:

  • bulb A: 350 (max since it cannot handle 370) <-- inconsistent state
  • bulb B: 370 (as expected)

An alternative implementation (solution B) could be that the range is set such that it fits all bulbs (in this case 150 - 350). The downside is that you cannot set bulb B to the max range anymore via the group.

What would be the preferred solution (a or b)?

@Koenkk
Copy link
Owner

Koenkk commented Jul 16, 2021

Implemented solution B now thanks for your input in 515599a#r53548408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants