Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist/block devices from joining? #816

Closed
simonvanderveldt opened this issue Jan 6, 2019 · 9 comments
Closed

Blacklist/block devices from joining? #816

simonvanderveldt opened this issue Jan 6, 2019 · 9 comments
Milestone

Comments

@simonvanderveldt
Copy link
Contributor

It seems like there are a couple devices in my vicinity that are joined to zigbee2mqtt as soon as I enable joining. Is there a way to block/blacklist specific devices from being allowed to join?

I couldn't find any info on this in the issues or documentation.

Koenkk added a commit that referenced this issue Jan 8, 2019
@Koenkk
Copy link
Owner

Koenkk commented Jan 8, 2019

Implemented in dev branch, can you verify this feature?

@simonvanderveldt
Copy link
Contributor Author

Cool, thanks! I can check it this week, at the latest this weekend. Is that OK?

@Koenkk
Copy link
Owner

Koenkk commented Jan 9, 2019

No problem :)

@stale
Copy link

stale bot commented Mar 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues label Mar 10, 2019
@tb-killa
Copy link
Contributor

@Koenkk your implementation use the defined function for remove devices.
As I see this on different devices it seems not work as it should do.
I think we should rebuild this and use a defined way to prevent them joining again.

How about add to our devices configuration part something like banned with the addr per device.
On controller side we should do something like this :
https://github.com/zigbeer/zigbee-shepherd/wiki#API_acceptDevIncoming

This would be a solid way.

@stale stale bot removed the stale Stale issues label Mar 10, 2019
@Koenkk Koenkk added this to the 1.3 milestone Mar 10, 2019
Koenkk added a commit that referenced this issue Mar 26, 2019
Koenkk added a commit that referenced this issue Mar 26, 2019
@Koenkk
Copy link
Owner

Koenkk commented Mar 26, 2019

Implemented!

Documentation: https://github.com/Koenkk/zigbee2mqtt.io/blob/dev/configuration/configuration.md (ban)

Devices banned through zigbee2mqtt/bridge/config/ban will also be added to this list.

Koenkk added a commit that referenced this issue Mar 26, 2019
@simonvanderveldt
Copy link
Contributor Author

Sorry, had some personal things get in the way. Should I still validate/test this?

@Koenkk
Copy link
Owner

Koenkk commented Mar 27, 2019

@simonvanderveldt yes, please :)

@Koenkk
Copy link
Owner

Koenkk commented Apr 4, 2019

Any updates?

@Koenkk Koenkk closed this as completed Apr 7, 2019
wilmardo pushed a commit to wilmardo/zigbee2mqtt that referenced this issue Sep 26, 2019
wilmardo pushed a commit to wilmardo/zigbee2mqtt that referenced this issue Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants