(feat) Expose Custom Clusters in MQTT #22583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Koenkk
reviewed
May 10, 2024
LaurentChardin
force-pushed
the
yokis
branch
2 times, most recently
from
84c8aa3
to
a44b101
Compare
LaurentChardin
added a commit
to LaurentChardin/zigbee2mqtt-frontend
that referenced
this pull request
May 16, 2024
- Supporting new topic `bridge/definitions` Introduced in Koenkk/zigbee2mqtt#22583 - Removing previously added files from `zigbee-herdsman`, but keeping the enum one
Koenkk
reviewed
May 16, 2024
Koenkk
reviewed
May 16, 2024
Koenkk
reviewed
May 16, 2024
Koenkk
reviewed
May 16, 2024
LaurentChardin
added a commit
to LaurentChardin/zigbee2mqtt-frontend
that referenced
this pull request
May 17, 2024
- Supporting new topic `bridge/definitions` Introduced in Koenkk/zigbee2mqtt#22583 - Removing previously added files from `zigbee-herdsman`, but keeping the enum one
Koenkk
reviewed
May 18, 2024
Koenkk
reviewed
May 18, 2024
Koenkk
reviewed
May 18, 2024
Koenkk
reviewed
May 18, 2024
|
A few more Once that's done, this can be merged. |
- Introducing bridge/definitions - Updating test case for custom clusters - Updating new path after ZCL revamp with 0.47.0 This change is needed for nurikk/zigbee2mqtt-frontend#2001
Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
LaurentChardin
added a commit
to LaurentChardin/zigbee2mqtt.io
that referenced
this pull request
May 20, 2024
- New topic: `bridge/definitions` - Related to Koenkk/zigbee2mqtt#22583
LaurentChardin
added a commit
to LaurentChardin/zigbee2mqtt-frontend
that referenced
this pull request
May 20, 2024
- Supporting new topic `bridge/definitions` Introduced in Koenkk/zigbee2mqtt#22583 - Removing previously added files from `zigbee-herdsman`, but keeping the enum one
Koenkk
added a commit
to Koenkk/zigbee2mqtt.io
that referenced
this pull request
May 21, 2024
* Updating MQTT docs about the newly added topic - New topic: `bridge/definitions` - Related to Koenkk/zigbee2mqtt#22583 * Update mqtt_topics_and_messages.md --------- Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
|
Many thanks for this PR 😄 |
Closed
Koenkk
pushed a commit
to nurikk/zigbee2mqtt-frontend
that referenced
this pull request
May 24, 2024
* feat(attributePicker): support custom attributes (#2001) - Update type definition to import Custom Clusters - Remove zh and zhc dependencies - Duplicate Cluster.ts file as this is becoming static - Updating references in components * fix(reporting): only display clusters declared by the device * feat(customclusters): refactoring the mqtt topic - Supporting new topic `bridge/definitions` Introduced in Koenkk/zigbee2mqtt#22583 - Removing previously added files from `zigbee-herdsman`, but keeping the enum one * feat(customclusters): updating github build script * feat(customclusters): fixing github action configuration * feat(customerclusters): fix pretty * feat(customclusters): fixing pnpm lock * feat(customclusters): fixing test cases * feat(customclusters): small revamp style * feat(customclusters): adding codebeatignore file and exclude test files * feat(customclusters): fixing ignore * feat(customclusters): fixing ignore * feat(customclusters): fixing pretty --------- Co-authored-by: Laurent Chardin <>
This was referenced Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this change is to expose Custom Clusters to the frontend UI, with the target to enable attribute listing in the dev-console page. Actually dev-console is retrieving Clusters definitions directly from the zh package, which will not work for Custom Clusters.
In order to do so, i propose to extend the function getDefinitionPayload with the custom_clusters object, as part of the device information. This will be publish as usual in the MQTT bridge/devices topic.
This change is needed for nurikk/zigbee2mqtt-frontend#2001 which will provide the frontend updates for dev-console.
UPDATE: design changed during implementation. See the thread of comments or refer to documentation starting with
1.37.2zigbee2mqtt-frontend: feat(attributePicker): support custom attributes (nurikk/zigbee2mqtt-frontend#2001) nurikk/zigbee2mqtt-frontend#2019zigbee2mqtt/bridge/definitions