-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: Home Assistant: remove duplicate sensor
/select
for select
/number
/button
entities
#25026
Conversation
I initially agreed to this and even made the change in one of the PRs, but since this has never been deprecated properly (no option to disable it) I think we should not put this in 2.0.0 |
How would you even deprecate it? Add another legacy setting that defaults to on for some versions? To follow semantic versioning, you'd have to remove it only in a 3.0.0 version that's probably very far beyond the horizon. Personally, I think the switch from 1.x to 2.x allows "binary breaks" even without a formal deprecation period ( |
These sensors have long been disabled by default in HA. I believe it's nearly safe to remove them given the current scope of breaking changes. I think this should be in 2.0.0. |
That's very true indeed, then let's merge this into 2.0.0 Before merging:
|
fb4f4f5
to
ffc6b3e
Compare
Sure 😄 You can try to parse them as you like, I did it as JSON: Removed I think we can just make a note that duplicate entities have been removed from the HA. |
sensor
for select
and number
entities in HAsensor
for select
and number
entities in HA
sensor
for select
and number
entities in HAsensor
/select
for select
/number
/button
entities
Breaking changes
This removes duplicate
sensor
forselect
andnumber
entities in Home Assistant.Additionally, it removes duplicate
select
forbutton
entities.It also removes removes duplicate
sensor
fortext
entities.Based on #24198 (comment)