Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ignore): Add back Home Assistant legacy action sensor #25192

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

Koenkk
Copy link
Owner

@Koenkk Koenkk commented Dec 13, 2024

@Nerivec
Copy link
Collaborator

Nerivec commented Dec 14, 2024

So, this turned into a much bigger job than anticipated...

  • Migration system wasn't quite ready for multi-step, fixed that...
  • Bumped settings version to 2.1 (provides support for dev users that already have migrated to 2.0.0)
  • Removed oneOf for homeassistant, availability and frontend => only object
    • Some nice code cleanups here and there with this one
    • Added defaults in schema and settings
  • Renamed getInternalSettings to getPersistedSettings
  • Updated example yaml
  • Fix tests

TODO:

  • If you want to keep Z2M version in sync with settings version, would need to update to 2.1.0
    • If not, probably should rename the log from migration-2.0.x-to-2.1.x.log to migration-2-to-2.1.log (same for tests labels)
  • Which is the expected default for homeassistant.status_topic (several occurrences)?
    • hass/status
    • homeassistant/status

@Koenkk Koenkk force-pushed the fix/ha-legacy-action-sensor branch from ccf755b to ff1291f Compare December 14, 2024 12:17
@Koenkk Koenkk merged commit 39c007d into dev Dec 14, 2024
42 checks passed
@Koenkk Koenkk deleted the fix/ha-legacy-action-sensor branch December 14, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants