Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mouse-specific PSSMs #83

Merged
merged 14 commits into from
Dec 9, 2022
Merged

Fix mouse-specific PSSMs #83

merged 14 commits into from
Dec 9, 2022

Conversation

christopher-mohr
Copy link
Collaborator

This

  • renames the mouse-specific Syfpeithi PSSMs
  • adds tests with mouse alleles.

Fixes #82.

@christopher-mohr christopher-mohr changed the base branch from develop to main December 9, 2022 09:41
@christopher-mohr christopher-mohr changed the base branch from main to develop December 9, 2022 09:42
jonasscheid
jonasscheid requested changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@jonasscheid jonasscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments here. Have you also checked if the nomenclature of mouse alleles for the external tools is right?

epytope/test/TestEpitopePrediction.py Show resolved Hide resolved
@christopher-mohr christopher-mohr merged commit 405889c into KohlbacherLab:develop Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasscheid jonasscheid jonasscheid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christopher-mohr @jonasscheid