Skip to content
This repository has been archived by the owner on Mar 11, 2022. It is now read-only.

Conversation

raffaelespazzoli
Copy link
Contributor

Pull Request Template

Description

this PR integrates eunomia with the operator-utils library.
the objectives of this library are:

  1. enforce some best practices when developing operators
  2. provide some common-use utility functions

The advantages for eunomia in adopting this library are:

  1. less code to maintain
  2. more readable code (especially in the reconcile cycle)
  3. basic status management
  4. basic error management
  5. basic event management

Fixes #23

Type of change

  • Refactoring

Copy link
Contributor

@etsauer etsauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raffaelespazzoli I see the Gopkg.lock was updated, but I don't see the update to add the new dependency to Gopkg.toml. Also, please make sure that we are pointing at a release of the operator-util repo.

@Smiley73 Smiley73 added the wip Work In Progress label Jun 7, 2019
@seanmalloy seanmalloy added this to the 0.0.1 milestone Jun 7, 2019
@seanmalloy
Copy link
Contributor

@raffaelespazzoli we planning on completing this work between 7/18 and 8/1.

@raffaelespazzoli
Copy link
Contributor Author

@seanmalloy I am stuck on this issue: kubernetes-sigs/controller-runtime#524
for some reason I am hitting it. The code port is complete but the unit tests don't work. Any help would be appreciated.

@seanmalloy
Copy link
Contributor

@raffaelespazzoli thanks for the info. this is in scope for our next sprint which starts 7/18, so we will try to figure it out.

@raffaelespazzoli raffaelespazzoli self-assigned this Jul 18, 2019
@Smiley73
Copy link
Contributor

What's the latest in this issue? Can we get this wrapped up?

@seanmalloy
Copy link
Contributor

It is assigned to @bjaroszewski. We will remove this from the 0.0.1 milestone if we do not have a resolution soon.

@seanmalloy seanmalloy removed this from the 0.0.1 milestone Aug 29, 2019
@seanmalloy
Copy link
Contributor

This pull request is currently on hold.

@seanmalloy
Copy link
Contributor

There are many conflicts now. We will not be merging this. Closing for now.

@seanmalloy seanmalloy closed this Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wip Work In Progress
Development

Successfully merging this pull request may close these issues.

Operator Best Practices Refactor
5 participants