Allocate empty object when doing Ethereum/ERC20 login #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 23, 2018 12:02
Update branch fullapidev with the updated upstream 'dev'
…llapidev Conflicts: gui/EasyDEX-GUI package.json
…ed more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automatingAdded more function to automating
I deleted the file install_Agama_my_fork.sh from the branch dev, that is the branch for exhange wuth the upstream dev branch, because it is a file for installing my local fork of Agama, and because the 'my' meaning in the file name is not clear.
Fullapidev
|
it's not safe to expose a token |
Lucioric2000
commented
Dec 8, 2018
|
This pull request was not about exposing the token, was about correcting a bug in the Eth/erc20 coins affter logging out and logging in again. |
|
I removed the files that exposed the token. |
|
The change that I wanted to do as a collaboration to the software is adding the line: |
|
thanks i added this change after you pointed out this bit |
Lucioric2000
pushed a commit
to Lucioric2000/Agama
that referenced
this pull request
Mar 6, 2019
Allocate empty object when doing Ethereum/ERC20 login
pbca26
pushed a commit
to pbca26/Agama
that referenced
this pull request
Dec 20, 2019
fix Verus version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding an ethereum coin, 0 balance is shown in a wallet, and an error message is shown in the console. The error message is that is tried to add a property to api.eth.connect when it contains a null value. For avoiding this situation, api.eth.connect must be assigned to an empty object when starting to work with a Ethereum wallet, this is, at login.
I also deleted the Agama installer file that is for my local fork, and created a small Python script that generates the development version string. But then is is needed to have Python installed in the system that does the install. If someone can convert the Python script (buildscripts/devversion.py) to a shell one...