feat: implement Pairing API #3
Open
+2,924
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimxy
reviewed
Oct 24, 2024
dimxy
reviewed
Oct 24, 2024
dimxy
reviewed
Oct 24, 2024
dimxy
reviewed
Oct 24, 2024
|
Great PR! (I left few notes above) |
dimxy
reviewed
Oct 25, 2024
|
I guess, I don't have right in this repo to resolve my review notes. @borngraced would you plz resolve them (including those you did not accept) |
|
ps: CI fmt and clippy checks fail |
shamardy
reviewed
Nov 8, 2024
pairing_api/src/pairing.rs
Outdated
Comment on lines
243
to
253
| pub async fn activate(&self, topic: &str) -> Result<(), PairingClientError> { | ||
| let expiry = self.expiry()?; | ||
|
|
||
| let mut pairings = self.pairings.lock().await; | ||
| if let Some(pairing) = pairings.get_mut(topic) { | ||
| pairing.pairing.active = true; | ||
| pairing.pairing.expiry = expiry + EXPIRY_30_DAYS; | ||
| } | ||
|
|
||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
Why not use this method above instead of code duplication?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the WalletConnect Pairing API, enabling secure communication between dApps and wallets. It manages pairing requests, responses, and lifecycle events (creating, deleting, extending, and pinging pairings).
Key features:
Test overview (
cargo run --example pairing):The test demonstrates the full lifecycle of a WalletConnect pairing, from establishment to termination, using the pairing_api and relay_client crates.
https://specs.walletconnect.com/2.0/specs/clients/core/pairing/
https://specs.walletconnect.com/2.0/specs/clients/core/crypto/crypto-keys
https://specs.walletconnect.com/2.0/specs/clients/core/pairing/data-structures
https://specs.walletconnect.com/2.0/specs/clients/core/pairing/pairing-api