feat(nspv): add auto login option

KomodoPlatform · Nov 19, 2019 · 02634f5 · 02634f5
1 parent be34a58
commit 02634f5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/modules/blockchain/antara/gaming/blockchain/nspv.system.cpp b/modules/blockchain/antara/gaming/blockchain/nspv.system.cpp
@@ -34,7 +34,7 @@ namespace antara::gaming::blockchain {
         LOG_SCOPE_FUNCTION(INFO);
     }
 
-    bool nspv::spawn_nspv_instance(const std::string &coin, std::optional<std::size_t> rpcport_in) noexcept {
+    bool nspv::spawn_nspv_instance(const std::string &coin, bool auto_login, std::optional<std::size_t> rpcport_in) noexcept {
         LOG_SCOPE_FUNCTION(INFO);
         std::ifstream ifs(tools_path_ / "coins");
         assert(ifs);
@@ -75,8 +75,10 @@ namespace antara::gaming::blockchain {
             DVLOG_F(loguru::Verbosity_ERROR, "error: {}", error.message());
             return false;
         }
-        if (auto wif = std::getenv("SECRET_WIF_WALLET"); wif != nullptr) {
-            registry_.at(coin).address = nspv_api::login(registry_.at(coin).endpoint, wif).address;
+        if (auto_login) {
+            if (auto wif = std::getenv("SECRET_WIF_WALLET"); wif != nullptr) {
+                registry_.at(coin).address = nspv_api::login(registry_.at(coin).endpoint, wif).address;
+            }
         }
         return true;
     }

diff --git a/modules/blockchain/antara/gaming/blockchain/nspv.system.hpp b/modules/blockchain/antara/gaming/blockchain/nspv.system.hpp
@@ -155,6 +155,7 @@ namespace antara::gaming::blockchain {
         static bool is_wif_wallet_exist() noexcept;
 
         bool spawn_nspv_instance(const std::string &coin,
+                                 bool auto_login = false,
                                  std::optional<std::size_t> rpcport_in = std::nullopt) noexcept;
 
         double get_balance(const std::string& coin) const noexcept;

diff --git a/modules/blockchain/antara/gaming/blockchain/nspv.system.tests.cpp b/modules/blockchain/antara/gaming/blockchain/nspv.system.tests.cpp
@@ -35,7 +35,7 @@ namespace antara::gaming::blockchain::tests {
         antara::gaming::ecs::system_manager mgr{entity_registry};
 
         auto &nspv_system = mgr.create_system<blockchain::nspv>(std::filesystem::current_path() / "nspv/assets/tools");
-                CHECK(nspv_system.spawn_nspv_instance("RICK"));
+                CHECK(nspv_system.spawn_nspv_instance("RICK", true));
                 CHECK_FALSE(blockchain::nspv::is_wif_wallet_exist());
                 CHECK_NOTHROW(nspv_system.set_pin_for_the_session("88691313"));