[r2r] use avg_blocktime from platform/utxo coin for l2/lightning #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamardy
changed the title
onur-ozkan
previously approved these changes
Jan 11, 2023
| @@ -61,6 +61,7 @@ fn start_lightning_nodes(enable_0_confs: bool) -> (MarketMakerIt, MarketMakerIt, | |||
| "estimate_fee_mode": "ECONOMICAL", | |||
| "mm2": 1, | |||
| "required_confirmations": 0, | |||
| "avg_blocktime": 600, | |||
There was a problem hiding this comment.
Could you use constant variable for all avg_blocktime fields in this module for same reason as #1601 (comment)
shamardy
dismissed stale reviews from sergeyboyko0791, onur-ozkan, and artemii235
via
9fd1d45
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since blocktimes in config will be in seconds after this PR KomodoPlatform/coins#573 is merged, lightning can now use the platform coin blocktime for estimating the number of blocks swap payments are locked for.