Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make blocktime in seconds #573

Merged
merged 6 commits into from
Mar 30, 2023
Merged

make blocktime in seconds #573

merged 6 commits into from
Mar 30, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Nov 23, 2022

closes #572
@artemii235 how best can we test this?

@smk762
Copy link
Collaborator Author

smk762 commented Nov 24, 2022

@smk762 smk762 marked this pull request as draft November 25, 2022 11:04
@smk762 smk762 mentioned this pull request Dec 14, 2022
@smk762 smk762 marked this pull request as ready for review January 7, 2023 09:41
@yurii-khi
Copy link

@smk762 I noticed that PR still has Awaiting API label. Do you by any chance know if related changes were implemented on api side? And if so, which version of api we should use for testing?

@smk762
Copy link
Collaborator Author

smk762 commented Jan 9, 2023

As I understand it, this field is only used for Tendermint at the moment. Since a recent update to API (KomodoPlatform/komodo-defi-framework#1526 (comment))
for tendermint configuration in coins file, avg_block_time is now called avg_blocktime.
@artemii235 can you pls confirm?

@smk762
Copy link
Collaborator Author

smk762 commented Jan 15, 2023

@artemii235 now that KomodoPlatform/komodo-defi-framework#1606 is merged, can we merge this one?

@artemii235
Copy link
Member

how best can we test this?

avg_blocktime is used in API only by Tendermint and Lightning protocols. If these can be activated, the config is correct.

now that KomodoPlatform/komodo-defi-framework#1606 is merged, can we merge this one?

Yes

Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anarkiVan
Copy link

@smk762 Hello! As I understand, if conflicts will be solved, the pr could be merged?

@smk762
Copy link
Collaborator Author

smk762 commented Feb 6, 2023

@smk762 Hello! As I understand, if conflicts will be solved, the pr could be merged?

Conflicts resolved, and tested as working on dev. Will await next API before merge as tendermint methods not yet in master / release binary

@smk762 smk762 merged commit 68d7e2e into master Mar 30, 2023
@cipig cipig deleted the seconds branch September 30, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set average block times in seconds for all coins.
5 participants