Update/mm2 kdf #1121
Merged
Update/mm2 kdf #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 9, 2024
|
We could also remove this parameter completely from coins file and code. The original use case of differentiating between coins compatible/tested with mm2/mm1 is long gone. Should there be any coin without mm2:1 set left, then we can remove it from coins file. |
I agree to this, I don't see the need for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precusor to replacing
mm2key in coins file tokdf. For now, both keys will exist in the file to avoid breaking reference apps. Once apps have performed the related update in their respective repos, themm2key can be removed.I'll open issues in the app and binary source repos to alert of this coming change.