fix(legacy-swap): check for confirmations on recover taker (#2242)

This commit fixes recover funds for taker when the swap was marked as unsuccessful due to the maker payment spend transaction not being confirmed. It also uses the required confirmations from coin config for taker/maker payment spend instead of using 1 confirmation max. This is because some chains require more than 1 confirmation for finality, e.g. Polygon.

mm2src/mm2_main/src/lp_swap/maker_swap.rs

@@ -1144,12 +1144,10 @@ impl MakerSwap {
     }
 
     async fn confirm_taker_payment_spend(&self) -> Result<(Option<MakerSwapCommand>, Vec<MakerSwapEvent>), String> {
-        // We should wait for only one confirmation to make sure our spend transaction is not failed.
-        // However, we allow the user to use 0 confirmations if specified.
         let requires_nota = false;
         let confirm_taker_payment_spend_input = ConfirmPaymentInput {
             payment_tx: self.r().taker_payment_spend.clone().unwrap().tx_hex.0,
-            confirmations: std::cmp::min(1, self.r().data.taker_payment_confirmations),
+            confirmations: self.r().data.taker_payment_confirmations,
             requires_nota,
             wait_until: self.wait_refund_until(),
             check_every: WAIT_CONFIRM_INTERVAL_SEC,

mm2src/mm2_main/src/lp_swap/taker_swap.rs

@@ -1854,11 +1854,9 @@ impl TakerSwap {
     }
 
     async fn confirm_maker_payment_spend(&self) -> Result<(Option<TakerSwapCommand>, Vec<TakerSwapEvent>), String> {
-        // We should wait for only one confirmation to ensure our spend transaction does not fail.
-        // However, we allow the user to use 0 confirmations if specified.
         let confirm_maker_payment_spend_input = ConfirmPaymentInput {
             payment_tx: self.r().maker_payment_spend.clone().unwrap().tx_hex.0,
-            confirmations: std::cmp::min(1, self.r().data.maker_payment_confirmations),
+            confirmations: self.r().data.maker_payment_confirmations,
             requires_nota: false,
             wait_until: self.wait_refund_until(),
             check_every: WAIT_CONFIRM_INTERVAL_SEC,
@@ -2105,8 +2103,8 @@ impl TakerSwap {
             return ERR!("Taker payment is refunded, swap is not recoverable");
         }
 
-        if self.r().maker_payment_spend.is_some() {
-            return ERR!("Maker payment is spent, swap is not recoverable");
+        if self.r().maker_payment_spend.is_some() && self.r().maker_payment_spend_confirmed {
+            return ERR!("Maker payment is spent and confirmed, swap is not recoverable");
         }
 
         let maker_payment = match &self.r().maker_payment {