Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SSL encryption to the RPC port #1324

Closed
cipig opened this issue Jun 23, 2022 · 3 comments
Closed

add SSL encryption to the RPC port #1324

cipig opened this issue Jun 23, 2022 · 3 comments

Comments

@cipig
Copy link
Member

cipig commented Jun 23, 2022

it would be helpful to have the RPC port SSL encrypted, so that mm2 instances can be managed over the network through the RPC port, eg for marketmaking bots dealing with more then one node
saw that we now have the option wss_certs... could that be simply applied to RPC too, like rpc_certs and if defined the RPC port will be encrypted with the cert?

@artemii235
Copy link
Member

It's possible, but you can also put a MM2 RPC behind the reverse proxy to reach the same goal. So it's unlikely to be implemented from the API side in near future.

@shamardy
Copy link
Collaborator

@cipig https was added in this PR #1861 which was merged to dev. You can close this issue once you test https and everything is working fine.

@cipig
Copy link
Member Author

cipig commented Jun 21, 2023

thanks, works fine
with \"https\":true, the RPC port is encrypted
if using self signed certs curl needs to be called with curl --insecure --url "https://127.0.0.1:7783"

works from remote too, with mm2 params \"https\":true,\"rpcip\":\"0.0.0.0\",\"rpc_local_only\":false and the remote IP in curl

@cipig cipig closed this as completed Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants