Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement secure (https) tcp connection in adex-cli #1873

Open
rozhkovdmitrii opened this issue Jun 21, 2023 · 2 comments · Fixed by #1910
Open

implement secure (https) tcp connection in adex-cli #1873

rozhkovdmitrii opened this issue Jun 21, 2023 · 2 comments · Fixed by #1910
Assignees
@rozhkovdmitrii
Labels
adex-cli

Comments

@rozhkovdmitrii
Copy link

rozhkovdmitrii commented Jun 21, 2023 •
edited
Loading

Impact

If we want CLI to work with remote nodes, then yes it should work over HTTP

Should be HTTPS, else the rpc password is sent in cleartext over internet.
There is an issue about this #1324 and i think it's an easy task.

Related links
@rozhkovdmitrii rozhkovdmitrii self-assigned this Jun 21, 2023
@rozhkovdmitrii
Copy link
Author

@shamardy, @cipig

@rozhkovdmitrii rozhkovdmitrii mentioned this issue Jun 21, 2023
Merged
@onur-ozkan onur-ozkan changed the title Provide sucure (https) connection to mm2 Provide secure (https) connection to mm2 Jun 21, 2023
@onur-ozkan onur-ozkan changed the title Provide secure (https) connection to mm2 implement secure (https) tcp connection in adex-cli Jun 21, 2023
@onur-ozkan
Copy link
Member

Provide secure (https) connection to mm2 was confusing since we already have it implemented, so I updated the title.

@rozhkovdmitrii rozhkovdmitrii linked a pull request Jul 11, 2023 that will close this issue
feat(adex-cli): secure connection provided #1910
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rozhkovdmitrii rozhkovdmitrii

Labels
adex-cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(adex-cli): secure connection provided KomodoPlatform/komodo-defi-framework
2 participants
@rozhkovdmitrii @onur-ozkan