Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating web3 crate #1565

Open
sergeyboyko0791 opened this issue Dec 6, 2022 · 4 comments
Open

Consider updating web3 crate #1565

sergeyboyko0791 opened this issue Dec 6, 2022 · 4 comments
Assignees

Comments

@sergeyboyko0791
Copy link

sergeyboyko0791 commented Dec 6, 2022

I tried to update web3 crate to use its web3::transport::Eip1193 as we discussed #1551 (comment)

I seem to update the dependencies correctly by forking parity-ethereum repo.
But then I faced too many compilation errors that should be handled on our side. They are mostly due to the changed relationship between ethereum-types, rlp and web3 crates.
Errors: https://gist.github.com/sergeyboyko0791/b3d1f2b4736ae98c3434bd76deb0db3e

I think that the effort to update the web3 crate doesn't worth it taking also into account that web3::transport::Eip1193 should be wrapped into a Send + Sync structure (using event-driven pattern).

cc: @artemii235

@sergeyboyko0791
Copy link
Author

A dev state (not to forget): c87e84c

@sergeyboyko0791
Copy link
Author

sergeyboyko0791 commented Dec 8, 2022

I faced a problem when tried to send RPC requests using an out-of-dated web3 crate: they used an old ethereum_types::U256 type that requires the number to start with 0x prefix on deserialization, but MetaMask RPC sometimes returns without the prefix.

So I decided to finish updating web3 crate. What I've gotten: 476e53c

@sergeyboyko0791 sergeyboyko0791 self-assigned this Dec 9, 2022
@sergeyboyko0791 sergeyboyko0791 linked a pull request Jan 2, 2023 that will close this issue
8 tasks
@dimxy
Copy link
Collaborator

dimxy commented Feb 1, 2024

There is a statement in the web3 client that we use https://crates.io/crates/web3 that it is not actively maintained and for new projects it is recommended to use another client: https://github.com/gakonst/ethers-rs. Maybe we should consider changing it too

@dimxy
Copy link
Collaborator

dimxy commented Feb 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants