[r2r] Complete MetaMask #1591

sergeyboyko0791 · 2022-12-28T16:14:41Z

Done:

Check if corresponding ETH chain is known by MetaMask wallet on coin activation using wallet_switchEthereumChain
Figure out how to refactor ETH/ERC20 withdraw taking into account that the only way to sign a transaction is to send it using eth_sendTransaction.
Extract address's public key using eth_singTypedDataV4 as Artem suggested Add possibility to login with metamask-like browser wallets #1167 (comment).
Update rust-web3 crate.
Perform swaps with coins activated with MetaMask.

TODO:

Figure out how to mock the MetaMask provider to test the swaps and the wallet functionality.
Design a notification protocol to notify the GUI on ETH account changed.
Find a workaround to sign/send Swap Watcher P2P messages

* Match MetaMask RPC error * Add and use `wallet_switch_ethereum_chain` RPC

* TODO error deserializing a nonce

* Fix `ethabi::Function::decode_input`

# Conflicts: # mm2src/coins/eth.rs # mm2src/coins/eth/web3_transport/metamask_transport.rs

* Wrap the `web3::Eip1193` transport into an event-driven pattern to make it `Send` * Fix circle dependencies by removing `serde_json::preserve_order` feature * Avoid using `serde_json::RawValue` for the `MmNumber`

* TODO figure out how to integrate `MetamaskSession` into `EthCoin`

* Add `MetamaskError` to all mm2 RPC errors * Get rid of `Web3Session` that makes the code super complicated

* Add `mm2_eth` crate with EIP712 helpers * Don't check ETH account on each RPC * Don't return a public key on `task::connect_metamask::init`

* Try to switch the ChainId on each RPC * Check if `WithdrawRequest::broadcast` is set

* Remove `url` and `version` fields from `AtomicDEXDomain` type

* Reimplement `ParityNonce` and `EthNonce` custom namespaces from `artemii235/rust-web3`

* Uninline extra `SwapOps` methods * Return a Lightning Node ID as an HTLC pubkey

onur-ozkan

Last review iteration from my side.

Thanks for the fixes for previous notes:rocket:

mm2src/crypto/src/metamask_ctx.rs

mm2src/crypto/src/metamask_login.rs

mm2src/coins/eth.rs

shamardy

Great work as always! only 2 comments from me

mm2src/coins/coin_errors.rs

mm2src/coins/eth.rs

shamardy

🔥

onur-ozkan

thanks for the fixes! looks good to me:)

artemii235

Re-approving.

ca333 · 2023-02-19T10:08:57Z

@sergeyboyko0791 plz resolve the conflicts

sergeyboyko0791 · 2023-02-19T10:41:12Z

@ca333 I would be happy to resolve them, but I can't push commits into this branch.
I'm waiting for #1651 to be merged first, because I try to merge sergeyboyko0791/atomicDEX-API/dev into KomodoPlatform/atomicDEX-API/dev. This is also the reason why I can't resolve #1633 PR issues.
@shamardy has approved the PR already.

ca333 · 2023-02-23T00:31:17Z

@ca333 I would be happy to resolve them, but I can't push commits into this branch. I'm waiting for #1651 to be merged first, because I try to merge sergeyboyko0791/atomicDEX-API/dev into KomodoPlatform/atomicDEX-API/dev. This is also the reason why I can't resolve #1633 PR issues. @shamardy has approved the PR already.

The fix/conflict-resolution could have been simply PR'd directly into https://github.com/KomodoPlatform/atomicDEX-API/tree/metamask-feature which would have resolved the situation. Either way, I will close this PR for #1674 . Thank you.

sergeyboyko0791 added 21 commits December 6, 2022 15:27

Save dev state

c87e84c

Check if corresponding ETH chain is known by MetaMask

f50a884

* Match MetaMask RPC error * Add and use `wallet_switch_ethereum_chain` RPC

Save withdraw dev state

b087c05

* TODO error deserializing a nonce

Fix compilation bugs after web3 update

476e53c

* Fix `ethabi::Function::decode_input`

Merge branch 'upgrade-web3' into metamask-feature

887a88f

# Conflicts: # mm2src/coins/eth.rs # mm2src/coins/eth/web3_transport/metamask_transport.rs

Fix nonce request by updating web3

ec817b2

Integrate web3::Eip1193 transport

d21695e

* Wrap the `web3::Eip1193` transport into an event-driven pattern to make it `Send` * Fix circle dependencies by removing `serde_json::preserve_order` feature * Avoid using `serde_json::RawValue` for the `MmNumber`

Refactor mm2_metamask by using web3::Eip1193

7bd0426

* TODO figure out how to integrate `MetamaskSession` into `EthCoin`

Lock MetamaskSession and switch ChainId if required on each RPC

99c43be

* Add `MetamaskError` to all mm2 RPC errors * Get rid of `Web3Session` that makes the code super complicated

Check if the MetMask account is still the same on each RPC

51390ff

Merge branch 'dev' into metamask-feature

9b66f09

Request to sign a Login request and extract pubkey

738b5cb

* Add `mm2_eth` crate with EIP712 helpers * Don't check ETH account on each RPC * Don't return a public key on `task::connect_metamask::init`

Add SwapOps::derive_htlc_pubkey

2937c56

Make sign_and_send_transaction_impl compatible with MetaMask wallet

d12ba9c

Read 'rpc_chain_id' param if chain_id is not set

881391c

* Try to switch the ChainId on each RPC * Check if `WithdrawRequest::broadcast` is set

Take project on task::connect_metamask::init request

5bec977

* Remove `url` and `version` fields from `AtomicDEXDomain` type

Minor changes

c2b43eb

Merge branch 'dev' into metamask-feature

02d730c

Push missing files

308a9aa

Import upstream rust-web3 crate

7210a5f

* Reimplement `ParityNonce` and `EthNonce` custom namespaces from `artemii235/rust-web3`

Import artemii235's parity-ethereum crate

4056ee7

sergeyboyko0791 changed the title ~~[wip] Complete MetaMask~~ [r2r] Complete MetaMask Dec 31, 2022

sergeyboyko0791 changed the title ~~[r2r] Complete MetaMask~~ [wip] Complete MetaMask Jan 2, 2023

This was linked to issues Jan 2, 2023

Add possibility to login with metamask-like browser wallets #1167

Open

Consider updating web3 crate #1565

Open

Fix tests

5ae56fd

sergeyboyko0791 force-pushed the metamask-feature branch from 21ad477 to 5ae56fd Compare January 2, 2023 11:15

sergeyboyko0791 added 3 commits January 2, 2023 13:26

Fix udeps

d2b86bd

Fix mm2_number tests

17eddf2

Fix test_wait_for_payment_spend_timeout

5f4ceb9

sergeyboyko0791 dismissed artemii235’s stale review via 31f4275 January 9, 2023 11:25

sergeyboyko0791 changed the title ~~[r2r] Complete MetaMask~~ [wip] Complete MetaMask Jan 9, 2023

shamardy mentioned this pull request Jan 10, 2023

Lightning integration #1045

Open

24 tasks

sergeyboyko0791 added 2 commits January 10, 2023 13:12

Minor changes

a85eb6c

* Uninline extra `SwapOps` methods * Return a Lightning Node ID as an HTLC pubkey

Merge branch 'dev' into metamask-feature

104fd0a

onur-ozkan requested changes Jan 10, 2023

View reviewed changes

sergeyboyko0791 added 2 commits January 11, 2023 13:50

Minor changes

b4b85b8

Implement SafeTypeCastingNumbers for U256

f5c6325

shamardy reviewed Jan 12, 2023

View reviewed changes

mm2src/coins/coin_errors.rs Outdated Show resolved Hide resolved

mm2src/coins/eth.rs Outdated Show resolved Hide resolved

sergeyboyko0791 added 3 commits January 12, 2023 12:59

Minor fix

e048546

Add a few more comments

1029c08

Consider web3::Error::Unreachable as a Transport error

c4706b5

sergeyboyko0791 changed the title ~~[wip] Complete MetaMask~~ [r2r] Complete MetaMask Jan 13, 2023

shamardy previously approved these changes Jan 13, 2023

View reviewed changes

Merge branch 'dev' into metamask-feature

f8689d3

onur-ozkan previously approved these changes Jan 15, 2023

View reviewed changes

Merge branch 'dev' into metamask-feature

0b6a4ff

sergeyboyko0791 dismissed stale reviews from onur-ozkan and shamardy via 0b6a4ff January 16, 2023 11:13

artemii235 previously approved these changes Jan 16, 2023

View reviewed changes

Merge branch 'dev' into metamask-feature

4f7d961

sergeyboyko0791 dismissed artemii235’s stale review via 4f7d961 January 23, 2023 10:21

ca333 self-requested a review February 10, 2023 12:27

ca333 requested a review from DeckerSU February 19, 2023 10:08

ca333 added the code conflicts label Feb 19, 2023

sergei-boiko mentioned this pull request Feb 22, 2023

[r2r] Complete MetaMask #1674

Merged

8 tasks

ca333 closed this Feb 23, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[r2r] Complete MetaMask #1591

[r2r] Complete MetaMask #1591

sergeyboyko0791 commented Dec 28, 2022

onur-ozkan left a comment

shamardy left a comment

shamardy left a comment

onur-ozkan left a comment

artemii235 left a comment

ca333 commented Feb 19, 2023

sergeyboyko0791 commented Feb 19, 2023 •

edited

Loading

ca333 commented Feb 23, 2023

[r2r] Complete MetaMask #1591

[r2r] Complete MetaMask #1591

Conversation

sergeyboyko0791 commented Dec 28, 2022

onur-ozkan left a comment

Choose a reason for hiding this comment

shamardy left a comment

Choose a reason for hiding this comment

shamardy left a comment

Choose a reason for hiding this comment

onur-ozkan left a comment

Choose a reason for hiding this comment

artemii235 left a comment

Choose a reason for hiding this comment

ca333 commented Feb 19, 2023

sergeyboyko0791 commented Feb 19, 2023 • edited Loading

ca333 commented Feb 23, 2023

sergeyboyko0791 commented Feb 19, 2023 •

edited

Loading