Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist order history #451

Closed
sindresorhus opened this issue Jun 29, 2019 · 8 comments
Closed

Persist order history #451

sindresorhus opened this issue Jun 29, 2019 · 8 comments
Assignees
@shamardy
Labels
enhancement New feature or request P1

Comments

@sindresorhus
Copy link

Just opening this so I can track when it's implemented.

It's a bit tricky situation as of now, MM2 doesn't persist the order history yet, order_status returns the active order info, but if it's matched it's not active anymore.
And it matches quite fast usually so yes, you might not have enough time to catch the order_status :slight_smile:
But if it's not matched it will stay online for 30 seconds and then be recreated as maker order.
@sindresorhus sindresorhus mentioned this issue Aug 5, 2019
Open
@artemii235 artemii235 added enhancement New feature or request P1 labels Apr 21, 2021
@artemii235
Copy link
Member

Bumping the issue, having order history is quite important. Worth implementing sooner than later.

@artemii235 artemii235 mentioned this issue Apr 30, 2021
Closed
@cipig
Copy link
Member

cipig commented May 3, 2021

one metric that could be relevant here: i have 9 base coins and almost 100 coins on one node... 2 orders per side (bid/ask)... that makes ~4000 orders (assuming all coins have balance) updated every 3 minutes

@shamardy shamardy mentioned this issue May 7, 2021
Merged
10 tasks
artemii235 pushed a commit that referenced this issue May 18, 2021
@shamardy
persist order history #451 (#936)
da02fa1 
* orders_history_uuids_by_filter API

* Fix Build Issue

* OrderStatus enum + order history inclue_details

* fix #[derive] removed when adding Todo comment

* fix wasm compilation and code formatting

* fix build error

* first review fixes

* fix dir name error

* second review fixes

* third review fixes

* Last review fixes
@smk762
Copy link

smk762 commented Dec 29, 2021

A doc for this exists at https://developers.komodoplatform.com/basic-docs/atomicdex-api-legacy/orders_history_by_filter.html
Please advise if it needs any edits. If not we can move it from "Documenting" to "Done"

@artemii235
Copy link
Member

@shamardy Could you please check it?

@shamardy
Copy link
Collaborator

A doc for this exists at https://developers.komodoplatform.com/basic-docs/atomicdex-api-legacy/orders_history_by_filter.html Please advise if it needs any edits. If not we can move it from "Documenting" to "Done"

result.details.order.changes_history should be removed from the response table as we don't use it anymore. Also the response example for changes history Response (details with history included) should be removed

smk762 added a commit to KomodoPlatform/developer-docs that referenced this issue Jan 1, 2022
@smk762
remove "changes_history"
362064a 
ref: KomodoPlatform/komodo-defi-framework#451 (comment)
@smk762 smk762 mentioned this issue Jan 1, 2022
Merged
@sergeyboyko0791
Copy link

@shamardy can we merge the mentioned PR and close this issue?

@shamardy
Copy link
Collaborator

shamardy commented Jan 4, 2022

@shamardy can we merge the mentioned PR and close this issue?

Yes, the docs PR can be merged

@smk762
Copy link

smk762 commented Jan 7, 2022

KomodoPlatform/developer-docs#344 merged

@smk762 smk762 closed this as completed Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shamardy shamardy

Labels
enhancement New feature or request P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sindresorhus @artemii235 @cipig @smk762 @shamardy @sergeyboyko0791