Allow to set dynamic fee in coins file.

[artemii235]

BCH has incompatible estimate fee request params so our estimate_fee calls do not work. As BCH daemon always returns 1000 sat per Kbyte we can just set this number in config e.g. in form {"fee_type":"Dynamic","sat_per_kb":1000}. This will do the trick.

NB

[cipig]

i think i found a better solution for the problem: switch wallet to https://github.com/BitcoinUnlimited/BitcoinUnlimited
which supports estimatesmartfee

bch-cli estimatesmartfee 1
{
  "feerate": 0.00001000,
  "blocks": 1
}

will test swaps with this wallet and if everything works, i will run own electrums with BitcoinUnlimited instead of bitcoin-abc

[artemii235]

Hi @cipig, thanks for finding the workaround!
I will keep this issue open because it might be still useful to have such option, but we can postpone the implementation for a while.

[cipig]

you were right keeping the issue open
unfortunately the estimatesmartfee method in BitcoinUnlimited is broken, after a while it starts showing weird values
start with 0.00001000, couple minutes later it is 0.00005021, than 0.00149997 and back to 0.00002202
that can't be, since all BCH txes are done with 1 sat/byte: https://blockchair.com/bitcoin-cash
and https://gitlab.com/bitcoin-cash-node/bitcoin-cash-node has the same problem as the original BCH wallet all started with

so we indeed need {"fee_type":"Dynamic","sat_per_kb":1000} for BCH

[cipig]

bch-cli estimatesmartfee 1
{
  "feerate": 0.00150780,
  "blocks": 1
}

bch-cli estimatesmartfee 2
{
  "feerate": 0.00001000,
  "blocks": 1
}

same result on all 3 electrums...
a possibility to set "estimate_fee_blocks": 2 just like "estimate_fee_mode": "ECONOMICAL" (for BTC) would also solve the problem

[artemii235]

a possibility to set "estimate_fee_blocks": 2 just like "estimate_fee_mode": "ECONOMICAL" (for BTC) would also solve the problem

I will focus on this specific topic this week.

[artemii235]

It's done. @cipig could you test the #804, please?

[cipig]

works perfect, thanks a lot
patched node: get_trade_fee shows 0.00001
unpatched node: get_trade_fee shows 0.00002834
not a big difference this time, but it could have been (the more time passes since last block, the higher the fee gets)
tried a swap too and it worked fine... started one with both nodes (patched and unpatched) and both BCH transactions were included in the next block
i think you can close the issue, since BCH was the only coin with this problem

[artemii235]

Thanks for testing!