Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add page_number for my_recent_swaps and my_tx_history. #780

Closed
artemii235 opened this issue Dec 25, 2020 · 1 comment
Closed

Add page_number for my_recent_swaps and my_tx_history. #780

artemii235 opened this issue Dec 25, 2020 · 1 comment
Assignees
@artemii235

Comments

@artemii235
Copy link
Member

The from_uuid approach is good for infinite scrolling implementation. But it's hard to implement pagination because the users of API don't know in advance what UUID will be on what page. Adding page_number params will ease the pagination implementation significantly. If both from_uuid and page_number are supplied, the MM2 will ignore page_number.
@artemii235 artemii235 self-assigned this Dec 25, 2020
@artemii235
Copy link
Member Author

PS. Thanks to @Milerius for this request!

artemii235 added a commit that referenced this issue Dec 26, 2020
@artemii235
Add page_number to my_tx_history and my_recent_swaps. Add active_swap…
014c4ea 
…s RPC.

#780 #781
@Milerius Milerius mentioned this issue Dec 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemii235 artemii235

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@artemii235