[feature request] wallet-only mode

[ca333]

Will be nice to have wallet-only mode for coins non-supported by DEX API.

[artemii235]

Thanks for opening the issue! We have a starting point for this already: https://github.com/KomodoPlatform/atomicDEX-API/blob/mm2.1/mm2src/coins/lp_coins.rs#L512, need to extend it to be configurable through coins file.

[artemii235]

Checklist

• Ensure that orderbook RPC returns an error if the base and/or rel are wallet only.
• best_orders should not accept the wallet-only coin as param.
• best_orders should filter out wallet-only coins orders from the response.
• Recheck that buy/sell/setprice returns an error if the base and/or rel are wallet only.
• trade_preimage should return an error if the base and/or rel are wallet only.
• orderbook_depth should return an error if at least 1 pair contains a wallet-only coin.

[shamardy]

@artemii235 I don't think we can use https://github.com/KomodoPlatform/atomicDEX-API/blob/335c96024620fe47bdcbc65021df821af6e6f54c/mm2src/coins/lp_coins.rs#L516 for orders since the orders methods referenced in the checklist don't use the coin implementations directly. I will be getting the wallet_only key straight from config for the above checklist. I will also implement the wallet_only method for the coins so it can be used later for anything else.

[artemii235]

for orders since the orders methods referenced in the checklist don't use the coin implementations directly. I will be getting the wallet_only key straight from config for the above checklist. I will also implement the wallet_only method for the coins so it can be used later for anything else.

True, I missed that we don't require coins to be activated in some RPCs 🙂 Yes, please use the key from config directly wherever fn wallet_only(&self) -> bool; is not available.

[artemii235]

@ca333 @tonymorony Omar has just implemented it, we can now proceed to use it in GUIs.