Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] trade_preimage has to use (volume * price) when swap_method is buy #867

Closed
sergeyboyko0791 opened this issue Mar 16, 2021 · 1 comment · Fixed by #869
Closed

[bug] trade_preimage has to use (volume * price) when swap_method is buy #867

sergeyboyko0791 opened this issue Mar 16, 2021 · 1 comment · Fixed by #869

Comments

@sergeyboyko0791
Copy link

swap_method has to take rel coin price or rel_volume.
As we discussed with @yurii-khi, it's better to take price instead of rel_volume.
@artemii235
Copy link
Member

Please also consider adding the total_fees (or similarly named field) to the response calculating e.g. the sum of all fees required to be paid in ETH.

@sergeyboyko0791 sergeyboyko0791 linked a pull request Mar 17, 2021 that will close this issue
Fix and refactor the trade_preimage RPC call #869
Merged
artemii235 pushed a commit that referenced this issue Mar 19, 2021
@sergeyboyko0791
Fix and refactor the trade_preimage RPC call (#869)
8faf623 
* Add the `price` field to the `trade_preimage` RPC request
* Add the `result.total_fees` field to the `trade_preimage` RPC response
* Add the `result.taker_fee.coin` filed
#867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix and refactor the trade_preimage RPC call KomodoPlatform/komodo-defi-framework
2 participants
@artemii235 @sergeyboyko0791