remove the fixed 0.00777 min_volume

[cipig]

Would be good if the 0.00777 fixed min_volume would be removed from code because it leads to situations like this from VRSC/BCH orderbook:

  "base": "VRSC",
  "bids": [
    {
      "coin": "BCH",
      "price": "0.001341967849711302791983569858186272612300851719483870844800364736125808734408438798418896163405842473",
      "maxvolume": "3.17658248",
      "min_volume": "0.00777",
      "base_max_volume": "2367.1077371066508",
      "base_min_volume": "5.79000458295",
      "rel_max_volume": "3.17658248",
      "rel_min_volume": "0.00777"
    },

0.00777 BCH rel_min_volume results in base_min_volume of 5.79 VRSC (1 VRSC is almost 1$) and there is actually no reason for it on this pair, because the txfees are low on BCH and VRSC.
The other reason for min_volume was the dust on some chains, but this was already fixed by using the real dust settings of the respective coins.

[artemii235]

Thanks for opening the issue! We will still need some reasonable min_volume because it can't be zero. Should we use 10 x dust for all UTXOs?

The other question is ETH: there is no dust at all for ETH, but we might possibly rely on the current gas price during calculations. However, it would be not clear how to handle the min_volume of ERC20 as we don't always have info about their price in relation to ETH.

Having the 0.00777 is actually simpler than answering the above questions 🙂

[artemii235]

@tonymorony Could you please advise on this? Maybe you will have a better idea 🙂

[cipig]

We will still need some reasonable min_volume because it can't be zero. Should we use 10 x dust for all UTXOs?

The UTXO coins have the lowest txfees (except BTC), so we could set min_volume to 10 x dust for all UTXO coins and keep the fixed 0.00777 for all other coins/tokens.
A simpler solution (also from GUI perspective, since i believe they use the fixed setting) would be to lower the fixed 0.00777 to a fixed 0.001 or so... at the current price this means a min_volume of 50$ for BTC pairs and 0.50$ for BCH pairs, which sounds reasonable to me.
Or we simply keep the current 0.00777 settings, which is ~435$ for BTC pairs and ~4$ for BCH pairs.

[cipig]

We now have BTC-BEP20 too, which has a low txfee compared to BTC. Would be nice if we could swap < 0.00777 BTC-BEP20. Lowering the fixed 0.00777 to a fixed 0.000777 or even lower would be the easiest solution i guess and it would cover BTC-BEP20 too, which is not a UTXO coin with dust.

[tonymorony]

@tonymorony Could you please advise on this? Maybe you will have a better idea 🙂

the only idea I have (at least so far) is to make a separate min_volume field in the coins file and maintain it manually depends on common sense and market conditions but it potentially can create a bit of mess (e.g. mobile GUI reparse this file so can miss the update and etc.)

[samurai321]

it's fine as is. obviusly i wish i can trade any amount but we are talking onchain trading.
i sure don't want people spamming 50$ btc trades that are going to cost a 20% or more in fees.
dogecoin is for that.

[cipig]

i sure don't want people spamming 50$ btc trades that are going to cost a 20% or more in fees.

BTC-BEP20 does not have such a high fee and is affected too... all coins with low fee and high USD price

[artemii235]

@cipig Could you please test changes from the linked PR? 🙂

[cipig]

works fine, i can now swap BUSD-BEP20 to BTC-BEP20 with min_volume 0.05$

[artemii235]

Done