Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SIGHASH_FORKID configurable through the coins file. #905

Closed
artemii235 opened this issue Apr 15, 2021 · 0 comments · Fixed by #912
Closed

Make SIGHASH_FORKID configurable through the coins file. #905

artemii235 opened this issue Apr 15, 2021 · 0 comments · Fixed by #912
Labels
enhancement New feature or request

Comments

@artemii235
Copy link
Member

It's hardcoded for BCH as of now: https://github.com/KomodoPlatform/atomicDEX-API/blob/8ca4d743a5799b949a6a036705b1b528caded160/mm2src/coins/utxo.rs#L919, but there are more coins using the SIGHASH_FORKID.
@artemii235 artemii235 added the enhancement New feature or request label Apr 15, 2021
This was referenced Apr 19, 2021
Merged
Merged
artemii235 pushed a commit that referenced this issue Apr 21, 2021
@shamardy
Make SIGHASH_FORKID configurable with coins file #905 (#912)
2b3db4f 
* Make SIGHASH_FORKID configurable with coins file

* added hardcoded BCH fork_id for non updated config

* fix code format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make SIGHASH_FORKID configurable with coins file shamardy/atomicDEX-API
1 participant
@artemii235