simple market maker bot #1066
Merged
simple market maker bot #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1065 - Add `start_simple_market_maker_bot` rpc call in dispatcher_v2.rs - Add `stop_simple_market_maker_bot` rpc call in dispatcher_v2.rs - Create a lp_bot.rs file and initiate the module in mm2.rs - Create a lp_bot_tests.rs file that contains unit test of the lp_bot module. - Add a context for the simple_trading_bot in mm_ctx.rs - Add a simple_market_maker.rs file that contains the simple trading bot logic. - Add the loop/logic for lp_price_service_loop (that fetch price every 20 seconds) - Add the loop of lp_bot_loop and an empty logic function - Add bot configuration data structure - Add price registry data structure Some notes: - There is too many logs right now in my implementation, I should reduce them.
…into simple_market_maker_bot
- Add a function to clone maker_order as read-only ops - Add a loop that iterate through maker orders and call update_single_order if the combination is found in cfg - Add update_single_order without any concrete logic.
artemii235
requested changes
Sep 14, 2021
mm2src/lp_bot/simple_market_maker.rs
Outdated
|
|
||
| pub async fn lp_bot_loop(ctx: MmArc) { | ||
| info!("lp_bot_loop successfully started"); | ||
| loop { |
There was a problem hiding this comment.
It looks like a good chance to start more extensive usage of the State machine pattern implemented by @sergeyboyko0791 🙂 Please check https://github.com/KomodoPlatform/atomicDEX-API/blob/mm2.1/mm2src/common/patterns/state_machine.rs. We plan to refactor some code parts to it in the future too.
… code review - Change `StartSimpleMakerBotAnswer` to `StartSimpleMakerBotRes` - Change `StopSimpleMakerBotAnswer` to `StopSimpleMakerBotRes` - Remove spurious usage of `return` - Sort alphabetically the dispatcher_v2 commands
artemii235
requested changes
Sep 30, 2021
- add a new log passthrough function that could be used
…into simple_market_maker_bot
artemii235
requested changes
Oct 5, 2021
artemii235
requested changes
Oct 7, 2021
…into simple_market_maker_bot
artemii235
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
Approved 🙂 @Milerius Thanks for your patience and good work on fixing all the remarks 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.