update_maker_order memory leak fix #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I started the lp node for 4 hours with four update orders - no memory leak so far. |
artemii235
reviewed
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #941 (comment)
@Milerius if this doesn't fix the memory leak then you can lower
TRIE_ORDER_HISTORY_TIMEOUThttps://github.com/KomodoPlatform/atomicDEX-API/blob/3402e6defc08092d3bf602da71bae81d37984d29/mm2src/lp_ordermatch.rs#L107 to less than 30 seconds maybe 15 or something to test if it's frominsert_new_diffhttps://github.com/KomodoPlatform/atomicDEX-API/blob/3402e6defc08092d3bf602da71bae81d37984d29/mm2src/lp_ordermatch.rs#L2215as it can be the other reason for the memory leak.