Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement enable_bch_with_tokens RPC. Refactoring #1145

Merged
merged 9 commits into from
Nov 22, 2021
Merged

Implement enable_bch_with_tokens RPC. Refactoring #1145

merged 9 commits into from
Nov 22, 2021

Conversation

artemii235
Copy link
Member

sergeyboyko0791
sergeyboyko0791 reviewed Nov 22, 2021
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks powerful and a bit complicated :D
Great work! I've left a few comments - no blockers.

mm2src/coins/utxo/bch.rs Outdated Show resolved Hide resolved
mm2src/coins_activation/src/platform_coin_with_tokens.rs Outdated Show resolved Hide resolved
mm2src/common/for_tests.rs Outdated Show resolved Hide resolved
Milerius
Milerius reviewed Nov 22, 2021
View reviewed changes
Copy link

@Milerius Milerius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question for me!

mm2src/coins_activation/src/prelude.rs Show resolved Hide resolved
sergeyboyko0791
sergeyboyko0791 approved these changes Nov 22, 2021
View reviewed changes
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, approve!

@artemii235 artemii235 merged commit d78b56d into dev Nov 22, 2021
@artemii235 artemii235 deleted the enable_v2_bch_with_tokens_activation branch November 22, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyboyko0791 sergeyboyko0791 sergeyboyko0791 approved these changes

@Milerius Milerius Milerius approved these changes

@shamardy shamardy Awaiting requested review from shamardy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artemii235 @Milerius @sergeyboyko0791