Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid log spam and malfunctioning electrums excessive reconnects #1193 #1161. #1194

Merged
merged 2 commits into from
Jan 17, 2022

Conversation

artemii235
Copy link
Member

@artemii235
Copy link
Member Author

Need to fix WASM, which will take a bit more time.

@artemii235 artemii235 closed this Jan 14, 2022
@artemii235
Copy link
Member Author

Finished the fixes.

@artemii235 artemii235 reopened this Jan 14, 2022
@artemii235 artemii235 changed the title Avoid log spam on malfunctioning electrums reconnects #1193 #1161. Avoid log spam and malfunctioning electrums excessive reconnects #1193 #1161. Jan 14, 2022
Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retried #1161 with "{\"method\":\"electrum\",\"coin\":\"KMD\",\"servers\":[{\"url\":\"electrum1.cipig.net:30001\",\"protocol\":\"SSL\"},{\"url\":\"electrum2.cipig.net:10001\"},{\"url\":\"electrum3.cipig.net:10001\"}]
electrum1.cipig.net:30001 is wrong, 30001 is WSS port, the other 2 electrums are correct

now mm2 shows this errors only every 5s

15 05:41:29, utxo:1533] Electrum electrum1.cipig.net:30001 server.version error "JsonRpcError { client_info: "coin: KMD", request: JsonRpcRequest { jsonrpc: "2.0", id: "1273", method: "server.version", params: [String("mpm GUI/MM2 b86134c12"), Array([String("1.2"), String("1.4")])] }, error: Transport("rpc_clients:1298] rpc_clients:2114] rpc_clients:2112] 60s timed out waiting for the future to complete") }".
15 05:41:30, coins:rpc_clients:1874] INFO Electrum client connected to electrum1.cipig.net:30001
15 05:41:30, coins:rpc_clients:1733] ERROR expected value at line 1 column 1
15 05:41:30, coins:rpc_clients:1733] ERROR expected value at line 1 column 1
15 05:41:30, coins:rpc_clients:1733] ERROR expected value at line 1 column 1
15 05:41:30, coins:rpc_clients:1733] ERROR expected value at line 1 column 1
15 05:41:30, coins:rpc_clients:1733] ERROR expected value at line 1 column 1
15 05:41:30, coins:rpc_clients:1733] ERROR expected value at line 1 column 1
15 05:41:30, coins:rpc_clients:1733] ERROR EOF while parsing a value at line 1 column 1
15 05:41:30, coins:rpc_clients:1733] ERROR expected value at line 1 column 1
15 05:41:30, coins:rpc_clients:1899] INFO EOF from electrum1.cipig.net:30001
15 05:41:30, coins:rpc_clients:1944] INFO electrum1.cipig.net:30001 connection dropped

not several times per second any more, and mm2 is usable

Copy link

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this mm2 with a few bad electrums (wrong url or port) no longer flooded logs with errors. Error messages still present, but appear at a much less frequent rate (every half second or so)

17 09:04:31, coins:rpc_clients:1872] ERROR "electrum1.cipig.net:11061" error Os { code: 111, kind: ConnectionRefused, message: "Connection refused" }
17 09:04:51, coins:rpc_clients:1845] ERROR "electrum4.cipig.net:10018" error "rpc_clients:1055] electrum4.cipig.net:10018 resolve error Custom { kind: Other, error: \"failed to lookup address information: Name or service not known\" }"
17 09:04:53, coins:rpc_clients:1845] ERROR "electrum4.cipig.net:10017" error "rpc_clients:1055] electrum4.cipig.net:10017 resolve error Custom { kind: Other, error: \"failed to lookup address information: Name or service not known\" }"
17 09:04:56, coins:rpc_clients:1872] ERROR "electrum1.cipig.net:11061" error Os { code: 111, kind: ConnectionRefused, message: "Connection refused" }
17 09:05:21, coins:rpc_clients:1845] ERROR "electrum4.cipig.net:10018" error "rpc_clients:1055] electrum4.cipig.net:10018 resolve error Custom { kind: Other, error: \"failed to lookup address information: Name or service not known\" }"
17 09:05:23, coins:rpc_clients:1845] ERROR "electrum4.cipig.net:10017" error "rpc_clients:1055] electrum4.cipig.net:10017 resolve error Custom { kind: Other, error: \"failed to lookup address information: Name or service not known\" }"
17 09:05:27, coins:rpc_clients:1872] ERROR "electrum1.cipig.net:11061" error Os { code: 111, kind: ConnectionRefused, message: "Connection refused" }
17 09:05:56, coins:rpc_clients:1845] ERROR "electrum4.cipig.net:10018" error "rpc_clients:1055] electrum4.cipig.net:10018 resolve error Custom { kind: Other, error: \"failed to lookup address information: Name or service not known\" }"
17 09:05:58, coins:rpc_clients:1845] ERROR "electrum4.cipig.net:10017" error "rpc_clients:1055] electrum4.cipig.net:10017 resolve error Custom { kind: Other, error: \"failed to lookup address information: Name or service not known\" }"
17 09:06:02, coins:rpc_clients:1872] ERROR "electrum1.cipig.net:11061" error Os { code: 111, kind: ConnectionRefused, message: "Connection refused" }
17 09:06:36, coins:rpc_clients:1845] ERROR "electrum4.cipig.net:10018" error "rpc_clients:1055] electrum4.cipig.net:10018 resolve error Custom { kind: Other, error: \"failed to lookup address information: Name or service not known\" }"
17 09:06:38, coins:rpc_clients:1845] ERROR "electrum4.cipig.net:10017" error "rpc_clients:1055] electrum4.cipig.net:10017 resolve error Custom { kind: Other, error: \"failed to lookup address information: Name or service not known\" }"

@artemii235 artemii235 merged commit e9707d4 into mm2.1 Jan 17, 2022
@artemii235 artemii235 deleted the mm2.1-electrum-log-spam branch January 17, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants