Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI pipeline for MacOS. #1202

Merged
merged 4 commits into from
Jan 28, 2022
Merged

Update CI pipeline for MacOS. #1202

merged 4 commits into from
Jan 28, 2022

Conversation

artemii235
Copy link
Member

No description provided.

Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!
I haven't seen how you refactored the CI build scripts before, so it's better later than never to say - well done 👍
Interesting thing - tests completed in 8m 26s on Mac mini M1 against 9m 58s on Mac mini 2013.
It seems to be due to a poor Docker performance on an ARM arch...

@artemii235 artemii235 merged commit b9a2ab1 into dev Jan 28, 2022
@artemii235 artemii235 deleted the macos-ci-configuration branch January 28, 2022 03:54
@artemii235
Copy link
Member Author

Interesting thing - tests completed in 8m 26s on Mac mini M1 against 9m 58s on Mac mini 2013.
It seems to be due to a poor Docker performance on an ARM arch...

@sergeyboyko0791 Even on Linux CI, which has the best performance, a full test run takes about 7 minutes. Hardware specs seem to have less effect on this as we have tests with explicit timeouts, etc. We will have to speed up them by optimizing our code 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants