Simultaneous activation of coins in two modes (Iguana and Trezor) #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor `CryptoCtx` to be a structure that contains `IguanaArc` always and a constructible `HwArc` * Add `init_trezor` RPC call that initializes `HwArc` * Rename `KeyPairCtx` to `IguanaCtx` * Comment out `mm_init_task`, `rpc_command` modules, `mm_init_status`, `mm_init_user_action` RPC calls
This was
linked to
issues
Mar 21, 2022
artemii235
reviewed
Mar 28, 2022
Milerius
reviewed
Mar 29, 2022
shamardy
reviewed
Mar 29, 2022
There was a problem hiding this comment.
LGTM! Other than @artemii235 and @Milerius comments couldn't find anything else worth mentioning 🙂 , will approve once those comments are resolved.
* Inherit `UtxoCommonOps` from `AsRef<UtxoCoinFields> + Clone + Send + Sync + 'static`
|
@artemii235 @Milerius I hope everything is done, could you please re-review the PR? :) |
Milerius
previously approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CryptoCtxto be a structure that containsIguanaArcalways and a constructibleHwArcinit_trezorRPC call that initializesHwArcKeyPairCtxtoIguanaCtxmm_init_task,rpc_commandmodules,mm_init_status,mm_init_user_actionRPC calls