[r2r] ARRR integration WIP. #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 14, 2022 19:11
# Conflicts: # Cargo.toml # mm2src/coins/z_coin.rs
|
@shamardy @ozkanonur @sergeyboyko0791 It's ready for next review iteration 🙂 |
shamardy
previously approved these changes
Apr 18, 2022
| let pubsecp = hex::encode(key_pair.public_slice()); | ||
|
|
||
| // Artem Vitae | ||
| // I tried if let Some(p2p_privkey) = order_mutex.lock().await.p2p_privkey |
There was a problem hiding this comment.
Cloning of the order has to be used to drop the mutex in this case, if let Some(p2p_privkey) = order_mutex.lock().await.clone().p2p_privkey will work but I guess just using drop(order) is ok as it avoids cloning.
artemii235
dismissed stale reviews from sergeyboyko0791 and shamardy
via
509117f
ca333
previously approved these changes
Apr 21, 2022
onur-ozkan
reviewed
Apr 21, 2022
| @@ -153,6 +153,10 @@ impl ZCoin { | |||
|
|
|||
| pub fn rpc_client(&self) -> &UtxoRpcClientEnum { &self.utxo_arc.rpc_client } | |||
|
|
|||
| pub fn is_sapling_state_synced(&self) -> bool { self.z_fields.sapling_state_synced.load(AtomicOrdering::Relaxed) } | |||
There was a problem hiding this comment.
I think it's better to inline this function.
|
@ozkanonur I've done all fixes, could you recheck the PR, please? |
Great work, looks good for me. 🔥 |
onur-ozkan
previously approved these changes
Apr 22, 2022
sergeyboyko0791
previously approved these changes
Apr 26, 2022
added 2 commits
April 27, 2022 14:19
# Conflicts: # mm2src/mm2_tests.rs
artemii235
dismissed stale reviews from sergeyboyko0791 and onur-ozkan
via
8eb9e1d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
orderbookandbest_orders2.0 RPCs.#927