Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r2r] Update WASM docs, fix my_recent_swaps in WASM #1264

Merged
merged 4 commits into from
Apr 27, 2022
Merged

Conversation

sergeyboyko0791
Copy link

  • Update WASM docs
  • Fix pagination by from_uuid in my_recent_swaps in WASM

@sergeyboyko0791 sergeyboyko0791 changed the title Update WASM docs, fix my_recent_swaps in WASM [wip] Update WASM docs, fix my_recent_swaps in WASM Apr 25, 2022
@sergeyboyko0791 sergeyboyko0791 changed the title [wip] Update WASM docs, fix my_recent_swaps in WASM [r2r] Update WASM docs, fix my_recent_swaps in WASM Apr 25, 2022
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! One change.

3. Download [Gecko driver](https://github.com/mozilla/geckodriver/releases) for your OS
4. Set `wasm-pack` specific environment variables
```
WASM_BINDGEN_TEST_TIMEOUT=120
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ALICE_PASSPHRASE and BOB_PASSPHRASE env vars are also required.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the note! Done

Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@artemii235 artemii235 merged commit c23b1f7 into dev Apr 27, 2022
@artemii235 artemii235 deleted the wasm-docs branch April 27, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants