[r2r] API call optimization #1279

caglaryucekaya · 2022-05-06T09:51:29Z

Requests current balance only for coins with an active maker order, as part of #1269.

artemii235

Thanks for the PR! It's the first review iteration.

mm2src/lp_ordermatch.rs

…nterval

…i-call-optimization

artemii235

Second review iteration.

artemii235 · 2022-05-09T09:49:25Z

mm2src/lp_ordermatch.rs

@@ -4263,6 +4275,37 @@ async fn get_max_volume(ctx: &MmArc, my_coin: &MmCoinEnum, other_coin: &MmCoinEn
    ))
 }

+pub async fn check_balance_update_loop(ctx: MmWeak, ticker: String) {
+    let mut current_balance = None;


Current balance is known when order is created. You can add it to fn arguments and simplify it a bit as Option won’t be used.

mm2src/lp_ordermatch.rs

mm2src/lp_ordermatch/my_orders_storage.rs

mm2src/lp_ordermatch.rs

…ncelled

artemii235

Next review iteration.

mm2src/lp_ordermatch.rs

artemii235 · 2022-05-11T07:11:40Z

@caglaryucekaya WASM build and test MM2_WASM_Linux CI stage fails now. Please track statuses and fix errors if they occur.

…i-call-optimization

artemii235

One change.

mm2src/lp_ordermatch.rs

artemii235 · 2022-05-11T10:36:20Z

@caglaryucekaya Also, there are 4 tests failing that have been stable:

docker_tests::docker_ordermatch_tests::test_zombie_order_after_balance_reduce_and_mm_restart
docker_tests::order_should_be_cancelled_when_entire_balance_is_withdrawn
docker_tests::order_should_be_updated_when_balance_is_decreased_alice_subscribes_after_update
docker_tests::order_should_be_updated_when_balance_is_decreased_alice_subscribes_before_update

And these should be related to this PR changes. Please check them and fix.

artemii235 · 2022-05-12T04:54:52Z

@caglaryucekaya rustfmt check is failing.

artemii235

Next review iteration.

mm2src/lp_ordermatch.rs

…i-call-optimization

artemii235

Last note :)

mm2src/mm2_main/src/lp_ordermatch.rs

artemii235

One more note.

mm2src/mm2_main/src/lp_ordermatch.rs

artemii235

Great work! 🙂 @sergeyboyko0791 @shamardy Please take a look too.

shamardy

I think we need to add balance loop if it doesn't exist for taker orders that get converted to maker in handle_timed_out_taker_orders, it would be good to also add a test case for this to not forget about it in the future if we were to change anything.

caglaryucekaya · 2022-06-23T10:02:32Z

mm2src/mm2_main/src/lp_ordermatch.rs

-        }
+        ordermatch_ctx
+            .makerorders_ctx
+            .lock()


@artemii235 here's the lock inside the loop

It's not a problem here as Taker->Maker order conversion is not that frequent :)

artemii235 · 2022-06-23T11:03:58Z

@sergeyboyko0791 Waiting for your review 🙂

shamardy

Amazing Work 🚀 !

sergeyboyko0791

Great progress!
Please consider my suggestions

mm2src/mm2_main/src/lp_ordermatch.rs

sergeyboyko0791 · 2022-06-23T13:32:12Z

mm2src/mm2_main/src/lp_ordermatch.rs

                    if !orderbook.order_set.contains_key(uuid) {
                        missing_uuids.push(*uuid);
                    }
                }
            }

            for uuid in missing_uuids {
-                let order_mutex = match ordermatch_ctx.my_maker_orders.lock().get(&uuid) {
+                let order_mutex = match ordermatch_ctx.makerorders_ctx.lock().orders.get(&uuid) {


I think it's better to add MakerOrdersContext::get_order method

mm2src/mm2_main/src/lp_ordermatch.rs

…i-call-optimization

sergeyboyko0791

Only one non-critical comment. If you have time, you can fix it, otherwise we can merge this PR

sergeyboyko0791 · 2022-06-24T11:51:29Z

mm2src/mm2_main/src/lp_ordermatch.rs

+        self.balance_loops.insert(ticker.to_string(), handle);
+    }
+
+    fn spawn_balance_loop(&mut self, ctx: MmWeak, order_base: &str, balance: Option<BigDecimal>) {


It's better to take order_base: String by value.

Sure I'll fix it

artemii235

🔥

Run current balance loop only for coins with active maker orders

38d612d

caglaryucekaya requested a review from artemii235 May 6, 2022 09:51

caglaryucekaya changed the title ~~API call optimization~~ [wip] API call optimization May 6, 2022

caglaryucekaya changed the title ~~[wip] API call optimization~~ [r2r] API call optimization May 6, 2022

artemii235 suggested changes May 6, 2022

View reviewed changes

mm2src/lp_ordermatch.rs Outdated Show resolved Hide resolved

mm2src/lp_ordermatch.rs Outdated Show resolved Hide resolved

caglaryucekaya changed the title ~~[r2r] API call optimization~~ [wip] API call optimization May 6, 2022

caglaryucekaya added 2 commits May 6, 2022 20:28

Use OrdermatchContext for maker orders and increase balance request i…

c90194f

…nterval

Merge branch 'dev' of github.com:KomodoPlatform/atomicDEX-API into ap…

ed20986

…i-call-optimization

caglaryucekaya changed the title ~~[wip] API call optimization~~ [r2r] API call optimization May 6, 2022

artemii235 suggested changes May 9, 2022

View reviewed changes

caglaryucekaya changed the title ~~[r2r] API call optimization~~ [wip] API call optimization May 9, 2022

Stop balance loops if the maker order of the corresponding coin is ca…

cb31353

…ncelled

caglaryucekaya changed the title ~~[wip] API call optimization~~ [r2r] API call optimization May 10, 2022

artemii235 suggested changes May 10, 2022

View reviewed changes

mm2src/lp_ordermatch.rs Outdated Show resolved Hide resolved

Prevent multiple balance loops running for the same coin

2100465

caglaryucekaya added 2 commits May 11, 2022 12:06

Fix WASM build problem

71ab99b

Merge branch 'dev' of github.com:KomodoPlatform/atomicDEX-API into ap…

c2efaf1

…i-call-optimization

artemii235 suggested changes May 11, 2022

View reviewed changes

mm2src/lp_ordermatch.rs Outdated Show resolved Hide resolved

caglaryucekaya changed the title ~~[r2r] API call optimization~~ [wip] API call optimization May 11, 2022

Use parking lot mutex for balance loops and fix docker test problems

b153c24

caglaryucekaya changed the title ~~[wip] API call optimization~~ [r2r] API call optimization May 11, 2022

Fix formatting problem

479ad79

artemii235 suggested changes May 12, 2022

View reviewed changes

mm2src/lp_ordermatch.rs Outdated Show resolved Hide resolved

mm2src/lp_ordermatch.rs Outdated Show resolved Hide resolved

caglaryucekaya changed the title ~~[r2r] API call optimization~~ [wip] API call optimization May 12, 2022

caglaryucekaya added 3 commits June 13, 2022 15:09

Merge branch 'dev' of github.com:KomodoPlatform/atomicDEX-API into ap…

7cfee74

…i-call-optimization

remove unused imports

9ee3a5d

Add MakerOrderContext in OrderMatchContext

1268d91

artemii235 suggested changes Jun 21, 2022

View reviewed changes

mm2src/mm2_main/src/lp_ordermatch.rs Outdated Show resolved Hide resolved

caglaryucekaya changed the title ~~[r2r] API call optimization~~ [wip] API call optimization Jun 21, 2022

Use thread handles to stop balance loops

b195a7a

caglaryucekaya changed the title ~~[wip] API call optimization~~ [r2r] API call optimization Jun 21, 2022

artemii235 suggested changes Jun 22, 2022

View reviewed changes

mm2src/mm2_main/src/lp_ordermatch.rs Outdated Show resolved Hide resolved

caglaryucekaya changed the title ~~[r2r] API call optimization~~ [wip] API call optimization Jun 22, 2022

caglaryucekaya added 2 commits June 22, 2022 11:15

Import spawn_abortable

daf1928

Fix format

736457f

caglaryucekaya changed the title ~~[wip] API call optimization~~ [r2r] API call optimization Jun 22, 2022

artemii235 previously approved these changes Jun 22, 2022

View reviewed changes

artemii235 requested review from sergeyboyko0791 and shamardy June 22, 2022 08:44

shamardy requested changes Jun 22, 2022

View reviewed changes

caglaryucekaya changed the title ~~[r2r] API call optimization~~ [wip] API call optimization Jun 22, 2022

Add balance loops after adding maker orders

0484951

caglaryucekaya dismissed artemii235’s stale review via 0484951 June 22, 2022 20:52

caglaryucekaya changed the title ~~[wip] API call optimization~~ [r2r] API call optimization Jun 22, 2022

caglaryucekaya commented Jun 23, 2022

View reviewed changes

shamardy previously approved these changes Jun 23, 2022

View reviewed changes

sergeyboyko0791 suggested changes Jun 23, 2022

View reviewed changes

Add further improvements

dc7dace

caglaryucekaya dismissed shamardy’s stale review via dc7dace June 23, 2022 19:34

Merge branch 'dev' of github.com:KomodoPlatform/atomicDEX-API into ap…

5f2caa7

…i-call-optimization

sergeyboyko0791 previously approved these changes Jun 24, 2022

View reviewed changes

Use String as spawn_balance_loop parameter

bb545fa

caglaryucekaya dismissed sergeyboyko0791’s stale review via bb545fa June 24, 2022 14:40

artemii235 approved these changes Jun 27, 2022

View reviewed changes

artemii235 merged commit 7203a05 into dev Jun 27, 2022

artemii235 deleted the api-call-optimization branch June 27, 2022 07:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[r2r] API call optimization #1279

[r2r] API call optimization #1279

caglaryucekaya commented May 6, 2022

artemii235 left a comment

artemii235 left a comment

artemii235 May 9, 2022

artemii235 left a comment

artemii235 commented May 11, 2022

artemii235 left a comment

artemii235 commented May 11, 2022

artemii235 commented May 12, 2022

artemii235 left a comment

artemii235 left a comment

artemii235 left a comment

artemii235 left a comment

shamardy left a comment

caglaryucekaya Jun 23, 2022

artemii235 Jun 23, 2022

artemii235 commented Jun 23, 2022

shamardy left a comment

sergeyboyko0791 left a comment

sergeyboyko0791 Jun 23, 2022

sergeyboyko0791 left a comment

sergeyboyko0791 Jun 24, 2022

caglaryucekaya Jun 24, 2022

artemii235 left a comment

[r2r] API call optimization #1279

[r2r] API call optimization #1279

Conversation

caglaryucekaya commented May 6, 2022

artemii235 left a comment

Choose a reason for hiding this comment

artemii235 left a comment

Choose a reason for hiding this comment

artemii235 May 9, 2022

Choose a reason for hiding this comment

artemii235 left a comment

Choose a reason for hiding this comment

artemii235 commented May 11, 2022

artemii235 left a comment

Choose a reason for hiding this comment

artemii235 commented May 11, 2022

artemii235 commented May 12, 2022

artemii235 left a comment

Choose a reason for hiding this comment

artemii235 left a comment

Choose a reason for hiding this comment

artemii235 left a comment

Choose a reason for hiding this comment

artemii235 left a comment

Choose a reason for hiding this comment

shamardy left a comment

Choose a reason for hiding this comment

caglaryucekaya Jun 23, 2022

Choose a reason for hiding this comment

artemii235 Jun 23, 2022

Choose a reason for hiding this comment

artemii235 commented Jun 23, 2022

shamardy left a comment

Choose a reason for hiding this comment

sergeyboyko0791 left a comment

Choose a reason for hiding this comment

sergeyboyko0791 Jun 23, 2022

Choose a reason for hiding this comment

sergeyboyko0791 left a comment

Choose a reason for hiding this comment

sergeyboyko0791 Jun 24, 2022

Choose a reason for hiding this comment

caglaryucekaya Jun 24, 2022

Choose a reason for hiding this comment

artemii235 left a comment

Choose a reason for hiding this comment