[r2r] HD wallet tx history #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `coins::tx_history_storage` module * Move `load_history`, `save_history`, `clear` from `TxHistoryDb` implementation to static functions
* Cover `BeBigUint` with unit tests
* Add `indexed_db::DbTable::count`, `indexed_db::DbTable::count_all` * Add methods to `indexed_db::DbTable` that take multiple index keys as arguments * Remove `DbTransaction::wait_for_complete` as it doesn't work properly
* Add tx history `WalletId` * Add `SqlQuery` that acts like `SqlBuilder` but manages parameters * Add `<WalletId>_tx_from_address`, `<WalletId>_tx_to_address` SQL tables
sergeyboyko0791
changed the title
onur-ozkan
requested changes
Jun 2, 2022
shamardy
reviewed
Jun 3, 2022
* Add `try_serialize_index_value` macro * Avoid declaring public methods, traits, types
artemii235
requested changes
Jun 8, 2022
* Move big JSON payloads to separate files * Add the `indexed_db::test_transaction_abort_on_error` test * Allow the `SqlQuery` to validate SQL identifiers and values
|
@sergeyboyko0791 Please solve git conflicts, so I can proceed with the next review iteration :) |
|
@ozkanonur @shamardy Could you please take one more look too? |
|
@artemii235 could you please share your thoughts on these TODOs? https://github.com/KomodoPlatform/atomicDEX-API/blob/f980fee5a524fdc390b2ecc7162eaee6edd2d380/mm2src/coins/tx_history_storage/sql_tx_history_storage_v2.rs#L619 This one can be done at the next iteration unless the transaction history v2 is integrated into AirDEX already. |
shamardy
previously approved these changes
Jun 10, 2022
...c/coins/for_tests/RICK_2c33baf0c40eebcb70fc22eab0158e315e2176e4a3f20acddcd849186fca492c.json
Outdated
Show resolved
Hide resolved
* Avoid adding `mm2src/coins/for_tests/RICK_<ID>.json` files
laruh
pushed a commit
that referenced
this pull request
Jun 16, 2022
#964 #740 * Restructure TX history storage modules * Add `coins::tx_history_storage` module * Move `load_history`, `save_history`, `clear` from `TxHistoryDb` implementation to static functions * Add `BeBigUint` into `common::indexed_db` * Cover `BeBigUint` with unit tests * Add `IndexedDbTxHistoryStorage` * Add `indexed_db::DbTable::count`, `indexed_db::DbTable::count_all` * Add methods to `indexed_db::DbTable` that take multiple index keys as arguments * Remove `DbTransaction::wait_for_complete` as it doesn't work properly * Integrate HD addresses into TxHistory V2 Storage scheme * Add tx history `WalletId` * Add `SqlQuery` that acts like `SqlBuilder` but manages parameters * Add `<WalletId>_tx_from_address`, `<WalletId>_tx_to_address` SQL tables * Minor changes * Add `try_serialize_index_value` macro * Avoid declaring public methods, traits, types * Fix PR issues * Move big JSON payloads to separate files * Add the `indexed_db::test_transaction_abort_on_error` test * Allow the `SqlQuery` to validate SQL identifiers and values * Combine `tx_from_address` and `tx_to_address` tables into single `tx_address` * Fix clippy warning * Fix PR issues * Avoid adding `mm2src/coins/for_tests/RICK_<ID>.json` files * Minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#964
#740
BeBigUinttomm2_db::indexed_db;IndexedDbTxHistoryStorage;mm2_db::indexed_db::DbTablewith the methods that take multiple index keys as arguments;WalletId(that may include HD walletrmd160);SqlQuerythat acts likeSqlBuilderbut also manages SQL parameters;<WalletId>_tx_from_address,<WalletId>_tx_to_addressSQL tablesPlease also note that I've left TODO comments with questions and suggestions how to improve the performance at the next iterations.