Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies, add unused dependencies check step to CI #1305

Merged
merged 13 commits into from
Jun 7, 2022

Conversation

shamardy
Copy link
Collaborator

@shamardy shamardy commented Jun 6, 2022

A few notes:

  • If cargo udeps fails on all CI agents (all operating systems), this means that the dependencies shown in the output should either be removed or are used in testing/wasm/features only, in this case these dependencies should be moved to the right target (e.g. [dev-dependencies], [target.'cfg(target_arch = "wasm32")'.dependencies]).
  • If cargo udeps fails on all CI agents (all operating systems) except one, then this is a dependency for this certain OS, in this case these dependencies should be moved to the right target (e.g. [target.'cfg(windows)'.dependencies]).

Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@artemii235 artemii235 merged commit 0f95b8d into dev Jun 7, 2022
@artemii235 artemii235 deleted the udeps-ci branch June 7, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants