Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2r] Fix rpc_password length constraints #1329

Merged
merged 2 commits into from
Jun 28, 2022
Merged

[r2r] Fix rpc_password length constraints #1329

merged 2 commits into from
Jun 28, 2022

Conversation

laruh
Copy link
Member

@laruh laruh commented Jun 28, 2022

Solving issue password_policy: constraints for rpc_password #1326

32 max length constraint was removed.

@laruh laruh requested a review from artemii235 June 28, 2022 09:06
artemii235
artemii235 requested changes Jun 28, 2022
View reviewed changes
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast fix! I have one minor note.

mm2src/mm2_main/src/mm2.rs Show resolved Hide resolved
artemii235
artemii235 approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@artemii235 artemii235 merged commit 312cf45 into dev Jun 28, 2022
@artemii235 artemii235 deleted the fix_constraints_rpc_password branch June 28, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemii235 artemii235 artemii235 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laruh @artemii235