Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2r] No login mode #1341

Merged
merged 4 commits into from
Jul 18, 2022
Merged

[r2r] No login mode #1341

merged 4 commits into from
Jul 18, 2022

Conversation

caglaryucekaya
Copy link

A quick fix to make MM2 work without a passphrase with a minimal initialization to allow the best_orders, orderbook, orderbook_depth and version RPC calls. Resolves #1318.

@caglaryucekaya caglaryucekaya changed the title No login mode [r2r] No login mode Jul 13, 2022
artemii235
artemii235 requested changes Jul 14, 2022
View reviewed changes
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fast implementation! A couple of notes on tests.

mm2src/mm2_main/src/mm2_tests.rs Outdated Show resolved Hide resolved
mm2src/mm2_main/src/mm2_tests.rs Outdated Show resolved Hide resolved
@caglaryucekaya caglaryucekaya changed the title [r2r] No login mode [wip] No login mode Jul 14, 2022
@caglaryucekaya caglaryucekaya changed the title [wip] No login mode [r2r] No login mode Jul 14, 2022
artemii235
artemii235 requested changes Jul 15, 2022
View reviewed changes
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor note 🙂

mm2src/mm2_main/src/lp_ordermatch/orderbook_rpc.rs Outdated Show resolved Hide resolved
@caglaryucekaya caglaryucekaya changed the title [r2r] No login mode [wip] No login mode Jul 15, 2022
@caglaryucekaya caglaryucekaya changed the title [wip] No login mode [r2r] No login mode Jul 15, 2022
artemii235
artemii235 approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@artemii235 artemii235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Done faster than I actually expected 🙂

@artemii235 artemii235 merged commit 3cce5af into dev Jul 18, 2022
@artemii235 artemii235 deleted the no-login-mode branch July 18, 2022 07:33
@caglaryucekaya caglaryucekaya mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemii235 artemii235 artemii235 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caglaryucekaya @artemii235