[r2r] Refactor HW API #1405
Merged
[r2r] Refactor HW API #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add an optional expected `device_pubkey` to the `init_trezor` request * Add connected `device_pubkey` to the `init_trezor_status` result * `init_trezor` has to be able to reinitialize a Hardware wallet
* Rename `WaitForTrezorPin` user action to `EnterTrezorPin` * Rename `ReadPublicKeyFromTrezor` in progress status to `WaitingForUserToConfirmPubkey` * Add `ticker` field to the `init_utxo`, `init_qtum` results
* Remove unused error types * Add `crypto::HwRpcError` * Replace HW related errors with `crypto::HwRpcError` for `init_utxo` RPC
* Replace HW related errors with `crypto::HwRpcError` for `init_withdraw` RPC
* Replace HW related errors with `crypto::HwRpcError` within `HDWalletRpcError` and `Mm2InitError` * Add `EnumFromTrait` and `EnumFromInner` derive macros
* Add `common::SerdeInfallible`
* Refactor `get_new_address` to return an error if the last address is not used yet * Split `HDWalletRpcError` into `GetNewAddressRpcError` and `CreateNewAccountRpcError`
* Add `task` RPC namespace, move all `init_*` methods there
* Add `EnterPassphrase` awaiting status * Add `TrezorPassphrase` user action
* Rename `InProgressStatus::WaitingForUserToConfirmPubkey` to `InProgressStatus::FollowHwDeviceInstructions`
* Replace `Ready` status with `Ok` and `Error` * Replace magic pubkey prefixes with `xpub` prefix on `TrezorSession::get_public_key`
* Create at least `min_addresses_number` addresses on coin activation * Allow to generate up to `gap_limit` empty addresses on `get_new_address` RPC * Improve `test_scan_for_new_addresses` test * Add `test_can_get_new_address` test * Implement `Debug` trait for `MmError` manually
sergeyboyko0791
removed request for
caglaryucekaya,
onur-ozkan,
borngraced and
laruh
artemii235
reviewed
Sep 1, 2022
This was referenced Sep 5, 2022
shamardy
requested changes
Sep 5, 2022
* Refactor `gen_new_addresses_if_required` * Fix deserializing `min_addresses_number` from legacy UTXO request * Remove `KEEP_XPUB_MAGIC` constant
|
@artemii235 @shamardy this PR is ready for the next review. |
|
@sergeyboyko0791 It can't be [r2r] because tests do not even compile. Please check your PR's CI status before putting [r2r] mark. UPD There are also conflicts that appeared after merging other PRs. |
|
@artemii235 now it's ready for the next review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#964
EnumFromTraitandEnumFromInnerderive macrosWaitForTrezorPinuser action toEnterTrezorPinReadPublicKeyFromTrezorin progress status toWaitingForUserToConfirmPubkeycrypto::HwRpcErrorforinit_trezor,init_utxo,init_qtum,init_withdraw,init_scan_for_new_addressesRPCsinit_trezordevice_pubkeyto theinit_trezorrequestdevice_pubkeyto theinit_trezor_statusresultinit_trezorhas to be able to reinitialize a Hardware walletinit_utxo,init_qtumtickerfield to theinit_utxo,init_qtumresults