[r2r] Fix P2P OrdermatchRequest backward compatibility. #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemii235
requested review from
shamardy,
onur-ozkan,
laruh and
sergeyboyko0791
shamardy
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
LGTM! I think we should add a comment about this on top of all enum variants that are used in P2P messages to not forget about it, similar to this https://github.com/KomodoPlatform/atomicDEX-API/blob/2af959c8ba514191b967c93cb86cb009d4dc1b0c/mm2src/mm2_main/src/lp_ordermatch.rs#L3713-L3716
onur-ozkan
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
LGTM. Agree with @shamardy, a doc-comment would be great for the developers.
@ozkanonur Will add in the dev branch after merging this hotfix 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New enum variants should be added to the end to keep the rmp_serde serialization numeration.