[r2r] Fix ARRR activation. More info to activation statuses. Check point block #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemii235
changed the title
shamardy
previously approved these changes
Aug 9, 2022
|
@sergeyboyko0791 @ozkanonur Could you please review it too? I assigned P0 to this because it's a hotfix required for ARRR GUI integration release. |
sergeyboyko0791
suggested changes
Aug 10, 2022
mm2src/coins/z_coin/z_rpc.rs
Outdated
| }) | ||
| .is_err() | ||
| { | ||
| debug!("No one seems interested in SyncStatus"); |
There was a problem hiding this comment.
Not critical. We could add LogOnError::debug_log_with_msg and use it here
onur-ozkan
requested changes
Aug 10, 2022
mm2src/coins/z_coin/z_rpc.rs
Outdated
| let mut from_block = self | ||
| .consensus_params | ||
| .sapling_activation_height | ||
| .max(current_block_in_db as u32 + 1) as u64; |
There was a problem hiding this comment.
current_block_in_db is already u32. No need to re-cast to same type.
There was a problem hiding this comment.
Hmm, get_latest_block now returns u32, missed it
artemii235
changed the title
artemii235
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Light wallet sync process could start from zero block, for which Sapling might be not activated yet. It caused unrecoverable error from lightwalletd with endless activation process on MM2 side.
#1427
KomodoPlatform/komodo-wallet#1775 (comment)