Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r2r] Mobile libs code fixes, build instructions and CI. #1463

Merged
merged 378 commits into from
Sep 13, 2022
Merged

Conversation

artemii235
Copy link
Member

@artemii235 artemii235 commented Sep 7, 2022

artemii235 and others added 30 commits June 20, 2019 08:38
Handle "history too large" in electrum mode properly #435

See merge request artemciy/supernet!33
Woraround for
`Undefined symbols for architecture arm64: "_daemon$1050", referenced from: ::unistd::daemon`
(nix using libc::daemon).

Should be unpinned when nix is no longer a dependency.
# Conflicts:
#	Cargo.lock
#	iguana/exchanges/LP_include.h
#	iguana/exchanges/LP_prices.c
#	mm2src/common/Cargo.toml
#	mm2src/common/common.rs
#	mm2src/lp_network.rs
# Conflicts:
#	Cargo.lock
#	mm2src/common/build.rs
#	mm2src/rpc/lp_signatures.rs
# Conflicts:
#	Cargo.lock
#	crypto777/OS_portable.c
#	crypto777/OS_portable.h
#	crypto777/curve25519.c
#	crypto777/iguana_OS.c
#	crypto777/iguana_utils.c
#	iguana/exchanges/LP_include.h
#	iguana/exchanges/LP_nativeDEX.c
#	iguana/exchanges/LP_prices.c
#	iguana/exchanges/LP_scan.c
#	includes/curve25519.h
#	includes/iguana_funcs.h
#	includes/iguana_globals.h
#	includes/iguana_structs.h
#	mm2src/coins/lp_coins.rs
#	mm2src/common/build.rs
#	mm2src/common/common.rs
#	mm2src/common/for_c.rs
#	mm2src/common/mm_ctx.rs
#	mm2src/mm2.rs
@artemii235 artemii235 marked this pull request as ready for review September 9, 2022 11:04
@artemii235 artemii235 changed the title [wip] Mobile libs code fixes, build instructions and CI. [r2r] Mobile libs code fixes, build instructions and CI. Sep 9, 2022
borngraced
borngraced previously approved these changes Sep 9, 2022
Copy link
Member

@borngraced borngraced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice thanks!
LGTM!

sergeyboyko0791
sergeyboyko0791 previously approved these changes Sep 9, 2022
Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Only one non-critical suggestion.

docs/ANDROID_CROSS_ON_M1_MAC.md Outdated Show resolved Hide resolved
shamardy
shamardy previously approved these changes Sep 10, 2022
Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
There is 1 empty REWRITE.md file added by this PR in docs directory and another empty directory coins in the root, not sure if those are needed or are leftovers.

@artemii235
Copy link
Member Author

@shamardy Those are leftovers, will remove shortly.

@artemii235
Copy link
Member Author

@sergeyboyko0791 @shamardy Notes are fixed, could you take one more look, please? 🙂

Copy link
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve

Copy link

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@artemii235 artemii235 merged commit 814a51e into mm2.1 Sep 13, 2022
@artemii235 artemii235 deleted the mm2.1-cross branch September 13, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants