-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[r2r] Mobile libs code fixes, build instructions and CI. #1463
Conversation
Handle "history too large" in electrum mode properly #435 See merge request artemciy/supernet!33
# Conflicts: # Cargo.lock
# Conflicts: # Cargo.lock # iguana/exchanges/LP_include.h # iguana/exchanges/LP_prices.c # mm2src/common/Cargo.toml # mm2src/common/common.rs # mm2src/lp_network.rs
# Conflicts: # Cargo.lock # mm2src/common/build.rs # mm2src/rpc/lp_signatures.rs
# Conflicts: # Cargo.lock # crypto777/OS_portable.c # crypto777/OS_portable.h # crypto777/curve25519.c # crypto777/iguana_OS.c # crypto777/iguana_utils.c # iguana/exchanges/LP_include.h # iguana/exchanges/LP_nativeDEX.c # iguana/exchanges/LP_prices.c # iguana/exchanges/LP_scan.c # includes/curve25519.h # includes/iguana_funcs.h # includes/iguana_globals.h # includes/iguana_structs.h # mm2src/coins/lp_coins.rs # mm2src/common/build.rs # mm2src/common/common.rs # mm2src/common/for_c.rs # mm2src/common/mm_ctx.rs # mm2src/mm2.rs
# Conflicts: # mm2src/mm2.rs
# Conflicts: # mm2src/mm2.rs
…ile apps release. Build debug temporary to speed up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice thanks!
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Only one non-critical suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There is 1 empty REWRITE.md
file added by this PR in docs
directory and another empty directory coins
in the root, not sure if those are needed or are leftovers.
@shamardy Those are leftovers, will remove shortly. |
5ae198b
@sergeyboyko0791 @shamardy Notes are fixed, could you take one more look, please? 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
#1464