Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce CHANGELOG.md #1680

Merged
merged 8 commits into from
Mar 8, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 98 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
## v1.0.0-beta <030623>

**Features:**
- [WIP] Lightning integration [#1045](https://github.com/KomodoPlatform/atomicDEX-API/issues/1045)
- [rust-lightning](https://github.com/lightningdevkit/rust-lightning) was updated to [v0.0.110](https://github.com/lightningdevkit/rust-lightning/releases/tag/v0.0.110) in [#1452](https://github.com/KomodoPlatform/atomicDEX-API/pull/1452)
- Inbound channels details was added to SQL channels history in [#1339](https://github.com/KomodoPlatform/atomicDEX-API/pull/1339)
- Blocking was fixed for sync rust-lightning functions that calls other I/O functions or that has mutexes that can be held for some time in [#1452](https://github.com/KomodoPlatform/atomicDEX-API/pull/1452)
- Default fees are retrieved from rpc instead of config when starting lightning [#1452](https://github.com/KomodoPlatform/atomicDEX-API/pull/1452)
- 0 confirmations channels feature was added in [#1452](https://github.com/KomodoPlatform/atomicDEX-API/pull/1452)
- An `update_channel` RPC was added that updates a channel that is open without closing it in [#1452](https://github.com/KomodoPlatform/atomicDEX-API/pull/1452)
- Lightning RPCs now use the `lightning::` namespace in [#1497](https://github.com/KomodoPlatform/atomicDEX-API/pull/1497)
- `TakerFee` and `MakerPayment` swap messages were modified to include payment instructions for the other side, in the case of lightning this payment instructions is a lightning invoice [#1497](https://github.com/KomodoPlatform/atomicDEX-API/pull/1497)
- `MakerPaymentInstructionsReceived`/`TakerPaymentInstructionsReceived` events are added to `MakerSwapEvent`/`TakerSwapEvent` in [#1497](https://github.com/KomodoPlatform/atomicDEX-API/pull/1497), for more info https://github.com/KomodoPlatform/atomicDEX-API/issues/1045#issuecomment-1410449770
- Lightning swaps were implemented in [#1497](https://github.com/KomodoPlatform/atomicDEX-API/pull/1497), [#1557
](https://github.com/KomodoPlatform/atomicDEX-API/pull/1557)
- Lightning swap refunds were implemented in [#1592](https://github.com/KomodoPlatform/atomicDEX-API/pull/1592)
- `MakerPaymentRefundStarted`, `TakerPaymentRefundStarted`, `MakerPaymentRefundFinished`, `TakerPaymentRefundFinished` events were added to swap error events in [#1592](https://github.com/KomodoPlatform/atomicDEX-API/pull/1592), for more info https://github.com/KomodoPlatform/atomicDEX-API/issues/1045#issuecomment-1410449770
- Enabling lightning now uses the task manager [#1513](https://github.com/KomodoPlatform/atomicDEX-API/pull/1513)
- Disabling lightning coin or calling `stop` RPC now drops the `BackgroundProcessor` which persists the latest network graph and scorer to disk [#1513](https://github.com/KomodoPlatform/atomicDEX-API/pull/1513), [#1490](https://github.com/KomodoPlatform/atomicDEX-API/pull/1490)
- `avg_blocktime` from platform/utxo coin is used for l2/lightning estimating of the number of blocks swap payments are locked for [#1606](https://github.com/KomodoPlatform/atomicDEX-API/pull/1606)
- Implemented `get_current_mtp` RPC #1340
- Custom enum from stringify derive macro to derive From implementations for enums #1502
- Validate that `input_tx` is calling `'receiverSpend'` in `eth::extract_secret` #1596
- Implement `SPV` with minimal storage requirements and fast block headers sync time #1585
- Implement block headers storage for `IndexedDB` and re-enable `SPV` in `WASM` #1644
- Validate all Swap parameters at the Negotiation stage #1475
under review stage as `r2r`(https://github.com/KomodoPlatform/atomicDEX-API/pull/1636):
- `ibc_withdraw`, `ibc_chains`, `ibc_transfer_channels` rpc implementations
- created new crate `mm2_git`(`git` functionality without 3rd party dependencies)
- implemented fetching & deserializing `cosmos/chain-registry` repository using `mm2_git`
- added `slurp_url_with_headers` function for native and wasm mode
- implemented tests for integrated features
- defined IBC commons in rust types and proto files in order to deserialize it in txs
- ARRR integration [#927](https://github.com/KomodoPlatform/atomicDEX-API/issues/927):
- Zcoin native mode support was added [#1438](https://github.com/KomodoPlatform/atomicDEX-API/pull/1438)
- multi lightwalletd servers support was added [#1472](https://github.com/KomodoPlatform/atomicDEX-API/pull/1472)
- Allow passing Zcash params file path to activation request [#1538](https://github.com/KomodoPlatform/atomicDEX-API/pull/1538)
- Checksum verification of Zcash params files was added [#1549](https://github.com/KomodoPlatform/atomicDEX-API/pull/1549)
- NFT integration [#900](https://github.com/KomodoPlatform/atomicDEX-API/issues/900)
- under review stage as [r2r] NFT proof of concept implementation [#1652](https://github.com/KomodoPlatform/atomicDEX-API/pull/1652)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still in review too

- gui-auth & enable_v2 rpc implementation https://github.com/KomodoPlatform/atomicDEX-API/commit/6631a20822a0a496b42b963c4ce05d58f69b7065
- tendermint htlc implementation https://github.com/KomodoPlatform/atomicDEX-API/commit/5e2dd3dd716d19fb99441d5a3d7ec185a120153a
- tendermint swap support(p.o.c level) https://github.com/KomodoPlatform/atomicDEX-API/commit/4de3cf2b24b914935b0d3f7364676b38275084fe
- created safe number type castings https://github.com/KomodoPlatform/atomicDEX-API/commit/535d6cb06ba17428226bbbadc00fc905b1cb00cc
- complete tendermint support for swaps and tx history implementation https://github.com/KomodoPlatform/atomicDEX-API/commit/15ff4c59496256c3e85c20ed4c3e4683be6c59dd
- Implement TX history V2 for UTXO coins activated with a Hardware wallet: https://github.com/KomodoPlatform/atomicDEX-API/pull/1576/commits/36392fdf1e36d290cec97181b85889bcae7abe8f
- Improve `stop` functionality https://github.com/KomodoPlatform/atomicDEX-API/pull/1576/commits/4a93790e01a1227d97cdb774fa52f34a694785cf
- Implement Global HD account activation mode https://github.com/KomodoPlatform/atomicDEX-API/pull/1576/commits/a05819d272278fc708a5ee42a6004edc80ec0e80
- Login with a MetaMask wallet https://github.com/KomodoPlatform/atomicDEX-API/pull/1576/commits/7ea1436d98aac6de3f9233a9ef5ec16badbf838b
- Add `max_maker_vol` RPC https://github.com/KomodoPlatform/atomicDEX-API/pull/1576/commits/7201146b3d2a4f95c6a080552faf8d7daa2a75e2
- Add `task::get_new_address::*` RPCs https://github.com/KomodoPlatform/atomicDEX-API/pull/1576/commits/6b4ec0f0383ffc5e9b5f3575a9a15d5ebfd36634

**Enhancements/Fixes:**
- A possible seednode p2p thread panicking attack due to `GetKnownPeers` msg was fixed in [#1445](https://github.com/KomodoPlatform/atomicDEX-API/pull/1445)
- NAV `cold_staking` script type was added to fix a problem in NAV tx history in [#1466](https://github.com/KomodoPlatform/atomicDEX-API/pull/1466)
- SPV was temporarily disabled in WASM in [#1479](https://github.com/KomodoPlatform/atomicDEX-API/pull/1479)
- `BTC-segwit` swap locktimes was fixed in [#1548](https://github.com/KomodoPlatform/atomicDEX-API/pull/1548) by using orderbook ticker instead of ticker in swap locktimes calculations.
- BTC block headers deserialization was fixed for version 4 and `KAWPOW_VERSION` in [#1452](https://github.com/KomodoPlatform/atomicDEX-API/pull/1452)
- Error messages for failing swaps due to a time difference between maker and taker are now more informative after [#1677](https://github.com/KomodoPlatform/atomicDEX-API/pull/1677)
- Fix `LBC` block header deserialization bug #1343
- Fix `NMC` block header deserialization bug #1409
- refactor mm2 error handling for some structures #1444
- Tx wait for confirmation timeout fix #1446
- Retry tx wait confirmation if not on chain #1474
- Fix electrum "response is too large (over 2M bytes)" error for block header download #1506
- Implement unit test for `Block header UTXO Loop` #1519
- Deactivate tokens with platform coin #1525
- enhanced logging in` spv` and `rpc_client` mods #1594
- update metrics related dep && refactoring #1312
- fix rick and morty genesis block deserialization #1647
- Include maker/taker pubkeys in MM2.db stats_swaps table #1665
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is still open for review and has not been merged to dev or main yet.

- solana based tests are ignored(because it's not completed and keeps failing the tests)
- temporary fix for https://github.com/KomodoPlatform/atomicDEX-API/pull/1576#issuecomment-1430170508
- in `librustzcash` bumped `bech32` to `0.9.1`(which we already have in mm2, so we will not have 2 versions of `bech32`)
- `chain_registry_name` field added to coins configuration for tendermint assets(part of ibc implementation PR)
- Use dev branch as a target branch for Dependabot [#1424](https://github.com/KomodoPlatform/atomicDEX-API/pull/1424)
- Fixed Zhtlc orders is_mine bug (orders had "is_mine":false) [#1489](https://github.com/KomodoPlatform/atomicDEX-API/pull/1489)
- Grouped SwapOps method arguments into new groups(structures) [#1529](https://github.com/KomodoPlatform/atomicDEX-API/pull/1529)
- Handling multiple rpcs optimization [#1480](https://github.com/KomodoPlatform/atomicDEX-API/issues/1480)
- Tendermint multiple rpcs optimization [#1568](https://github.com/KomodoPlatform/atomicDEX-API/pull/1568)
- Multiple rpcs optimization for `z_rpc` and `http_transport` [#1653](https://github.com/KomodoPlatform/atomicDEX-API/pull/1653)
- refactor p2p message processing flow(related with one of the security problem) https://github.com/KomodoPlatform/atomicDEX-API/commit/957fd856fb74d462058a5ad47ec46d79e3bf1d83
- Small fixes https://github.com/KomodoPlatform/atomicDEX-API/commit/f552644cd470945aa14f4d2f2fd48a527add23bf, https://github.com/KomodoPlatform/atomicDEX-API/commit/b27a9a4351fad141a5e941b5b4b774ee3895e810, https://github.com/KomodoPlatform/atomicDEX-API/commit/174519747298b13f68b6de0dadb5b0dc84df7c3d
- solana tests are disabled https://github.com/KomodoPlatform/atomicDEX-API/commit/0c507ccba561d3296f58ea3bac9bc52fbdab3378
- some of vulnerable dependencies(tokio, libp2p) are fixed https://github.com/KomodoPlatform/atomicDEX-API/commit/7ad381963ff463986a4c647b1d7f14f115fbbd66, https://github.com/KomodoPlatform/atomicDEX-API/commit/5f83b09f867da12416bae14a56177a5ed11629cf
- bugfix & improvement on tendermint rpc client rotation https://github.com/KomodoPlatform/atomicDEX-API/commit/95fc67dfcd92949dde9fea3acb4bfb7d4bd9d473
- Fix KMD withdraw with Trezor, add `mm2_stop` WASM FFI https://github.com/KomodoPlatform/atomicDEX-API/pull/1576/commits/1086720487942457855590ac206c7f771edd4e44
- Use `futures_timer` crate and fix unstable tests https://github.com/KomodoPlatform/atomicDEX-API/pull/1576/commits/14b145d84f54c9b5e9deec1e13252cf6c07bd241
- Fix `Timer::sleep_ms` in WASM https://github.com/KomodoPlatform/atomicDEX-API/pull/1576/commits/3618e7f2cff95aac273df8c77c84e014a530c247
- Fix a race condition in `AbortableQueue` https://github.com/KomodoPlatform/atomicDEX-API/pull/1576/commits/2c1524dfdcaad68ccabbefc7caa3dfd73e8926d5
- Spawn `process_json_request` so the RPC requests can be processed asynchronously https://github.com/KomodoPlatform/atomicDEX-API/pull/1576/commits/90ce38a57c8be11d915c8af891b00a17030f97be
- Fix `task::-::cancel` if the RPC task is an awaiting status https://github.com/KomodoPlatform/atomicDEX-API/pull/1576/commits/4f1190b7fc16972b22f6399b7264bd57a9d2d2b1
- disable_coin should fail if there are tokens dependent on the platform https://github.com/KomodoPlatform/atomicDEX-API/pull/1576/commits/0f3967903a1177225d030d8f4006adefed4ad671
- implement a repeatable future https://github.com/KomodoPlatform/atomicDEX-API/pull/1576/commits/9f1f4e927197ea5a30cdff3b88bcc744a906f7aa
- Use a shared DB for HD accounts storage https://github.com/KomodoPlatform/atomicDEX-API/pull/1576/commits/6f8d35c200684800a04234331837fc8abbe48e72

**NB - Backwards compatibility breaking changes:**
- Because of [#1548](https://github.com/KomodoPlatform/atomicDEX-API/pull/1548), old nodes will not be able to swap BTC segwit with new nodes since locktimes are exchanged and validated in the negotiation messages.
Empty file.
Empty file.
Empty file removed dev-logs/2023-feb/fixes/.gitkeep
Empty file.
4 changes: 0 additions & 4 deletions dev-logs/2023-feb/fixes/fix_swap_time_difference_err_message

This file was deleted.

Empty file.
6 changes: 0 additions & 6 deletions dev-logs/2023-feb/upgrades/axum_core_upgrade_to_0_2_9

This file was deleted.

6 changes: 0 additions & 6 deletions dev-logs/2023-feb/upgrades/bumpalo_upgrade_to_3_12_0

This file was deleted.

6 changes: 0 additions & 6 deletions dev-logs/2023-feb/upgrades/libp2p_upgrade_to_0_45_1

This file was deleted.

6 changes: 0 additions & 6 deletions dev-logs/2023-feb/upgrades/tokio_upgrade_to_1_25_0

This file was deleted.