Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r2r] Add change logs for PRs merged to dev only #1702

Merged
merged 6 commits into from
Mar 14, 2023
Merged

Conversation

shamardy
Copy link
Collaborator

@shamardy shamardy commented Mar 8, 2023

No description provided.

@shamardy shamardy changed the title Add change logs for PRs merged to dev only [r2r] Add change logs for PRs merged to dev only Mar 8, 2023
laruh
laruh previously approved these changes Mar 9, 2023
Copy link
Member

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additions!
I have one non-blocking note

CHANGELOG.md Outdated
@@ -1,3 +1,14 @@
## {version} - {date}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just leave "dev only" instead of {version} - {date}?
When there will be a new release, feature will be moved from dev to release list.
Or just put a note under the version-date that its the dev list

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will add a note that this is the dev branch list and {version} - {date} should be updated when there is a new release. Thanks.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added dev branch instead of {version} - {date}

@shamardy shamardy merged commit 159b1b5 into dev Mar 14, 2023
@shamardy shamardy deleted the docs-update-changelog branch March 14, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants