-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[r2r] Add change logs for PRs merged to dev only #1702
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additions!
I have one non-blocking note
CHANGELOG.md
Outdated
@@ -1,3 +1,14 @@ | |||
## {version} - {date} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just leave "dev only" instead of {version} - {date}?
When there will be a new release, feature will be moved from dev to release list.
Or just put a note under the version-date that its the dev list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I will add a note that this is the dev branch list and {version} - {date}
should be updated when there is a new release. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added dev branch
instead of {version} - {date}
No description provided.